Re: [Kile-devel] \includegraphics position options patch -- bug 160806

[Thomas B. <br...@ph...>]

On Freitag, 20. Februar 2009, David Lonie wrote:
> I didn't send this to the list the first time -- please forgive any
> duplicates :)

Hi David,

no problem. The layout of the dialog looks good and it works :)

> Here's my first patch for kile -- if someone could check it over to
> make sure things are done consistently with the rest of kile, it'd be
> a good idea :) It works as expected for me, and should close 160806. I
> did not include the scale= options, but I can add that if we think
> it's necessary.

Well what do you think about even more options?
KLineEdits for scale and trim and checkboxes for keepaspectratio and clip?
This is according to http://en.wikibooks.org/wiki/LaTeX/Importing_Graphics the 
full list.

>
> I do have a quick question -- I included the code to talk to
> KileConfig and store the position options (igTop, etc), but I can't
> figure out why this is done. Could someone give me a quick explanation
> why? The only reason I could think of is to save selections so that
> the last used options would appear when calling the dialog, but this
> doesn't seem to be the case.
I have no clue why it is not working, I'll investigate that later.
An additional LineEdit for the position tags would be nice to be able to use 
custom position flags (e.g. H from the float package)

And I think unchecking all position flags by default is savest as this would 
lead to no change from the user point of view compared to kile 2.0.

Thanks for your patch,
Thomas