From: Eugene S. <eug...@gm...> - 2013-03-19 14:23:22
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/ ----------------------------------------------------------- Review request for Kile and Michel Ludwig. Description ------- It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. Diffs ----- src/CMakeLists.txt b0b03cc src/dialogs/configurationdialog.cpp cfcf8ff src/dialogs/quotesconfigdialog.h PRE-CREATION src/dialogs/quotesconfigdialog.cpp PRE-CREATION src/dialogs/quotesconfigdialog.ui PRE-CREATION src/editorextension.h e963129 src/editorextension.cpp fc3906b src/kile.kcfg cff4670 src/models/quotesmodel.h PRE-CREATION src/models/quotesmodel.cpp PRE-CREATION src/widgets/latexconfigwidget.h 57b699d src/widgets/latexconfigwidget.cpp 6d4a975 src/widgets/latexconfigwidget.ui 502f688 Diff: http://git.reviewboard.kde.org/r/109582/diff/ Testing ------- Thanks, Eugene Shalygin |
From: Michel L. <mic...@gm...> - 2013-03-19 19:39:47
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/#review29509 ----------------------------------------------------------- src/CMakeLists.txt <http://git.reviewboard.kde.org/r/109582/#comment22011> Can you move this to the 'dialogs' folder? or 'dialogs/models'? src/editorextension.h <http://git.reviewboard.kde.org/r/109582/#comment22012> Can you call this 'predefinedQuotes' instead of 'staticQuotes' everywhere? Also, can you use two separate lists, one for the predefined ones and one for the user quotes? src/editorextension.cpp <http://git.reviewboard.kde.org/r/109582/#comment22014> Can you some encode '@' if it occurs in one of the strings? like '\@' (and '\' becomes '\\') src/editorextension.cpp <http://git.reviewboard.kde.org/r/109582/#comment22013> Actually, why is 'id' needed at all? src/widgets/latexconfigwidget.cpp <http://git.reviewboard.kde.org/r/109582/#comment22015> Isn't it possible to simply pass the same model (m_quotesModel)to the QuotesConfigDialog? The path looks good already, there was just one issue when I tried it out - namely, no quote style was selected when I started Kile. Ideally, it would be good to have a mechanism to translate the previous quote style (using numbers) to the new representation in the configuration file. - Michel Ludwig On March 19, 2013, 2:02 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 2:02 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: http://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |
From: Eugene S. <eug...@gm...> - 2013-03-20 16:05:01
|
> On March 19, 2013, 7:39 p.m., Michel Ludwig wrote: > > src/CMakeLists.txt, line 152 > > <http://git.reviewboard.kde.org/r/109582/diff/1/?file=120380#file120380line152> > > > > Can you move this to the 'dialogs' folder? or 'dialogs/models'? Since it is used from widgets folder also, will it make sence? > On March 19, 2013, 7:39 p.m., Michel Ludwig wrote: > > src/editorextension.cpp, line 3500 > > <http://git.reviewboard.kde.org/r/109582/diff/1/?file=120386#file120386line3500> > > > > Actually, why is 'id' needed at all? To allow user rename user types and to support localization of labels > On March 19, 2013, 7:39 p.m., Michel Ludwig wrote: > > src/widgets/latexconfigwidget.cpp, line 62 > > <http://git.reviewboard.kde.org/r/109582/diff/1/?file=120391#file120391line62> > > > > Isn't it possible to simply pass the same model (m_quotesModel)to the QuotesConfigDialog? As for me, this would make handling of "Reset" action in the dialog more complicated and we will need to update combo box value on every edit, as its value is binded to the specific model index On March 19, 2013, 7:39 p.m., Eugene Shalygin wrote: > > The path looks good already, there was just one issue when I tried it out - namely, no quote style was selected when I started Kile. Ideally, it would be good to have a mechanism to translate the previous quote style (using numbers) to the new representation in the configuration file. One can use the following scheme: if config parameter "doubleQuotes" consists of a digit only, and there are no user specified quotes, this digit is an index. See updated patch - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/#review29509 ----------------------------------------------------------- On March 19, 2013, 2:02 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 2:02 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: http://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |
From: Eugene S. <eug...@gm...> - 2013-03-20 16:07:26
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/ ----------------------------------------------------------- (Updated March 20, 2013, 4:07 p.m.) Review request for Kile and Michel Ludwig. Changes ------- Resolve pointed out issues, sort user quotes list before displaying it to user and saving to config file, plus various small fixes Description ------- It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. Diffs (updated) ----- src/CMakeLists.txt b0b03cc src/dialogs/configurationdialog.cpp cfcf8ff src/dialogs/quotesconfigdialog.h PRE-CREATION src/dialogs/quotesconfigdialog.cpp PRE-CREATION src/dialogs/quotesconfigdialog.ui PRE-CREATION src/editorextension.h e963129 src/editorextension.cpp fc3906b src/kile.kcfg cff4670 src/models/quotesmodel.h PRE-CREATION src/models/quotesmodel.cpp PRE-CREATION src/widgets/latexconfigwidget.h 57b699d src/widgets/latexconfigwidget.cpp 6d4a975 src/widgets/latexconfigwidget.ui 502f688 Diff: http://git.reviewboard.kde.org/r/109582/diff/ Testing ------- Thanks, Eugene Shalygin |
From: Eugene S. <eug...@gm...> - 2013-03-20 16:15:21
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/#review29567 ----------------------------------------------------------- I forgot to remove two commented out lines. I'm sorry. But it does not worth a new diff revision, I think? - Eugene Shalygin On March 20, 2013, 4:07 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 4:07 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: http://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |
From: Eugene S. <eug...@gm...> - 2013-04-11 11:22:11
|
> On March 20, 2013, 5:15 p.m., Eugene Shalygin wrote: > > I forgot to remove two commented out lines. I'm sorry. But it does not worth a new diff revision, I think? Ping - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109582/#review29567 ----------------------------------------------------------- On March 20, 2013, 5:07 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 5:07 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: http://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |
From: Ryan M. <rya...@gm...> - 2014-10-30 20:28:35
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109582/#review69555 ----------------------------------------------------------- Could you please add some kind of tool tip for the configuration? Specifically to explain the difference between the identifier and the label. - Ryan McCoskrie On March 20, 2013, 4:07 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 4:07 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Repository: kile > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: https://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |
From: Eugene S. <eug...@gm...> - 2014-11-03 09:34:57
|
> On Oct. 30, 2014, 9:28 p.m., Ryan McCoskrie wrote: > > Could you please add some kind of tool tip for the configuration? Specifically to explain the difference between the identifier and the label. The difference is: the identifier is stored in the configuration file, while the label is displayed to a user in the quotes selection combo box. This is needed for built-in quote types since their labels needs to be localizable. For user-defined quote types localization seems to be almost impossible (if user does not choose already localized strings as a label). If presence of identifier is confusing (for user-defined labels), perhaps it has to be removed from the table. Then the table will show only user quote types and the text in the combo box has to show quotes symbols also, since there is no other way to see them. For user types these strings might be long, that is not beatiful. That is why I decided that identifier in the table is less evil. If someone can suggest nice tooltips (there are some, but not good), I would be thankful. - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109582/#review69555 ----------------------------------------------------------- On March 20, 2013, 5:07 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109582/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 5:07 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Repository: kile > > > Description > ------- > > It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog. > > > Diffs > ----- > > src/CMakeLists.txt b0b03cc > src/dialogs/configurationdialog.cpp cfcf8ff > src/dialogs/quotesconfigdialog.h PRE-CREATION > src/dialogs/quotesconfigdialog.cpp PRE-CREATION > src/dialogs/quotesconfigdialog.ui PRE-CREATION > src/editorextension.h e963129 > src/editorextension.cpp fc3906b > src/kile.kcfg cff4670 > src/models/quotesmodel.h PRE-CREATION > src/models/quotesmodel.cpp PRE-CREATION > src/widgets/latexconfigwidget.h 57b699d > src/widgets/latexconfigwidget.cpp 6d4a975 > src/widgets/latexconfigwidget.ui 502f688 > > Diff: https://git.reviewboard.kde.org/r/109582/diff/ > > > Testing > ------- > > > Thanks, > > Eugene Shalygin > > |