From: David L. <lon...@gm...> - 2009-02-20 15:41:28
Attachments:
bug160806-includegraphics-position.patch
|
I didn't send this to the list the first time -- please forgive any duplicates :) Here's my first patch for kile -- if someone could check it over to make sure things are done consistently with the rest of kile, it'd be a good idea :) It works as expected for me, and should close 160806. I did not include the scale= options, but I can add that if we think it's necessary. I do have a quick question -- I included the code to talk to KileConfig and store the position options (igTop, etc), but I can't figure out why this is done. Could someone give me a quick explanation why? The only reason I could think of is to save selections so that the last used options would appear when calling the dialog, but this doesn't seem to be the case. Dave |
From: Thomas B. <br...@ph...> - 2009-02-20 18:20:18
|
On Freitag, 20. Februar 2009, David Lonie wrote: > I didn't send this to the list the first time -- please forgive any > duplicates :) Hi David, no problem. The layout of the dialog looks good and it works :) > Here's my first patch for kile -- if someone could check it over to > make sure things are done consistently with the rest of kile, it'd be > a good idea :) It works as expected for me, and should close 160806. I > did not include the scale= options, but I can add that if we think > it's necessary. Well what do you think about even more options? KLineEdits for scale and trim and checkboxes for keepaspectratio and clip? This is according to http://en.wikibooks.org/wiki/LaTeX/Importing_Graphics the full list. > > I do have a quick question -- I included the code to talk to > KileConfig and store the position options (igTop, etc), but I can't > figure out why this is done. Could someone give me a quick explanation > why? The only reason I could think of is to save selections so that > the last used options would appear when calling the dialog, but this > doesn't seem to be the case. I have no clue why it is not working, I'll investigate that later. An additional LineEdit for the position tags would be nice to be able to use custom position flags (e.g. H from the float package) And I think unchecking all position flags by default is savest as this would lead to no change from the user point of view compared to kile 2.0. Thanks for your patch, Thomas |
From: David L. <lon...@gm...> - 2009-02-20 23:12:36
Attachments:
bug160806-includegraphics-position-2.patch
|
On Fri, Feb 20, 2009 at 12:20 PM, Thomas Braun <br...@ph...> wrote: > Well what do you think about even more options? > KLineEdits for scale and trim and checkboxes for keepaspectratio and clip? > This is according to http://en.wikibooks.org/wiki/LaTeX/Importing_Graphics the > full list. > > And I think unchecking all position flags by default is savest as this would > lead to no change from the user point of view compared to kile 2.0. How's this? I cleaned up some of the signal/slot tangle and rearranged the dialog a bit, too. Dave |
From: Thomas B. <br...@ph...> - 2009-02-21 13:28:21
|
On Freitag, 20. Februar 2009, David Lonie wrote: > On Fri, Feb 20, 2009 at 12:20 PM, Thomas Braun > > <br...@ph...> wrote: > > Well what do you think about even more options? > > KLineEdits for scale and trim and checkboxes for keepaspectratio and > > clip? This is according to > > http://en.wikibooks.org/wiki/LaTeX/Importing_Graphics the full list. > > > > And I think unchecking all position flags by default is savest as this > > would lead to no change from the user point of view compared to kile 2.0. > > How's this? I cleaned up some of the signal/slot tangle and rearranged > the dialog a bit, too. Very nice. One more thing :) Could you make the dialog a bit less wide? If I open it here it covers half of kile. After that it is ready for inclusion. Do you have svn commit rights? If yes, feel free to add it after the last change, if no just send the patch again and I can add it. bye, Thomas |
From: Michel L. <mic...@kd...> - 2009-02-21 17:14:15
|
Hi, On Fri 20 Feb 2009, David Lonie wrote: > Here's my first patch for kile -- if someone could check it over to > make sure things are done consistently with the rest of kile, it'd be > a good idea :) It works as expected for me, and should close 160806. I > did not include the scale= options, but I can add that if we think > it's necessary. There is a little spelling mistake: prefered -> preferred Michel |