From: Thomas B. <br...@ph...> - 2008-09-20 16:27:58
|
Hello everybody, the below patch is in my eyes not needed. Nothing crashes while accessing a qstring with the at method and an index out of bounds. See http://doc.trolltech.com/3.3/qstring.html#at. Is it okay if I revert it? SVN commit 862017 by *: Fix crash if you have a document with \begin{block} M +1 -1 documentinfo.cpp --- trunk/extragear/office/kile/src/documentinfo.cpp #862016:862017 @@ -1033,7 +1033,7 @@ else if(m=="block" || m=="exampleblock" || m=="alertblock") { const QString untitledBlockDisplayName = i18n("Untitled Block"); it = m_dictStructLevel.find("\\begin{block}"); - if(s.at(tagEnd+1) == '{') { + if(tagEnd+1 < s.size() && s.at(tagEnd+1) == '{') { tagEnd++; result = matchBracket(i, tagEnd); m = result.value.trimmed(); ------------------------------------------------------- |
From: Rob B. <rob...@gm...> - 2009-04-01 04:29:53
|
Could someone take care of this for me? Also: would it be possible to get bugzilla access? Rob ---------- Forwarded message ---------- From: <bug...@kd...> Date: Tue, Mar 31, 2009 at 9:06 PM Subject: Re: extragear/office/kile/src To: Robertson Bayer <rob...@gm...> You tried to change the Status field from UNCONFIRMED to RESOLVED , but only the assignee or reporter of the bug, or a user with the required permissions may change that field. Robertson Bayer wrote: > @bug_id = 146913 > @bug_status = RESOLVED > @resolution = FIXED > > SVN commit 947663 by rbayer: > > StructureView support for graphic files without extensions. Configurable on both project and global levels. > > BUG: 146913 > > M +24 -0 dialogs/projectdialogs.cpp > M +2 -1 dialogs/projectdialogs.h > M +4 -0 kile.cpp > M +4 -0 kile.kcfg > M +10 -0 kileinfo.cpp > M +5 -0 kileinfo.h > M +11 -0 kileproject.cpp > M +4 -1 kileproject.h > M +48 -2 widgets/structureviewconfigwidget.ui > M +29 -3 widgets/structurewidget.cpp > > > WebSVN link: http://websvn.kde.org/?view=rev&revision=947663 |
From: Michel L. <mic...@kd...> - 2009-04-01 07:15:35
|
On Wed 01 Apr 2009, Rob Bayer wrote: > Could someone take care of this for me? > > Also: would it be possible to get bugzilla access? Done & done. :-) Michel |