This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111484/

On September 4th, 2013, 7:57 p.m. CEST, Michel Ludwig wrote:

Thanks for suggesting a fix. I've now committed a slightly different version.
Perfect! Thanks!

- Eugene


On August 13th, 2013, 8:46 p.m. CEST, Eugene Shalygin wrote:

Review request for Kile and Michel Ludwig.
By Eugene Shalygin.

Updated Aug. 13, 2013, 8:46 p.m.

Description

There is a bug in Kile: after one cancels ongoing compilation, it is not possible to launch compilation again.

I believe the problem is caused by the fact that compilation tool is only stopped, but not removed from the queue. Therefore it seats forever at the front of the queue and prevents next tools from run.
This review request proposes to call Manager::done(..., KileTool::Aborted) after stopping the tool.

Testing

Manual. Start/abort/start compilation sequence works

Diffs

  • src/kiletoolmanager.cpp (696bbd7)

View Diff