|This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108971/|
On March 28th, 2013, 4:56 p.m. UTC, Michel Ludwig wrote:According to the API documentation, 'KColorScheme::shade' should automatically choose the 'right' colour for the shade: Note Shades are chosen such that all shades would contrast with the base color. This means that if base is very dark, the 'dark' shades will be lighter than the base color, with midlight() == shadow(). Conversely, if the base color is very light, the 'light' shades will be darker than the base color, with light() == mid(). It feels like this could be a bug rather than something which should fixed in Kile. Could you check?
Michel, I'm afraid I do not understand your comment. As we use "DarkShade" explicitly as a shade mode, how can we expect a lighter colour for the shade? So shade is indeed in contrast with the base colour, but it is absolutely non contrast to the background, colour of which is unknown to shade() function. Do you agree?
On March 27th, 2013, 5:24 p.m. UTC, Eugene Shalygin wrote:
Review request for Kile and Michel Ludwig.
By Eugene Shalygin.
Updated March 27, 2013, 5:24 p.m.