This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109777/

Thanks Eugene.

I think it would even be better if "triggerAction" wouldn't have to be called at all. Could you maybe replace the call to "triggerAction" with the respective

QAction *action = m_view->action("bla");
if(action) {
  action->trigger();
}

in "kilescriptdocument.cpp"? (you could also introduce a method for just doing that)

I guess the same could be done for the actions that belong to Kile, even by calling the methods directy via KileInfo, and then we could remove "Manager::initScriptActions()"
altogether in "scriptmanager.cpp".

- Michel


On March 28th, 2013, 11:46 a.m. UTC, Eugene Shalygin wrote:

Review request for Kile and Michel Ludwig.
By Eugene Shalygin.

Updated March 28, 2013, 11:46 a.m.

Description

As per discussion in the mail list.

Do not add "tools_.+" actions to the actions collection. Try to get action which is not found in the action collection from the current view

Testing

manual

Diffs

  • src/scripting/kilescriptdocument.cpp (7c5dfde)
  • src/scriptmanager.cpp (2687794)

View Diff