|This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106617/|
On September 28th, 2012, 8:48 p.m., Michel Ludwig wrote:Ok, let's see how well this will work :)
On September 28th, 2012, 9:33 p.m., Eugene Shalygin wrote:I would say that it works much better with https://git.reviewboard.kde.org/r/106567/ applied :)
On September 28th, 2012, 9:50 p.m., Eugene Shalygin wrote:Michel, I see that commit 56f4e5bf9bc98c1ae0b948dd0568cbb66a5bbec7 does not include adding of source(false) to dependencies in LaTeX::updateBibs(). Why it is so? Suppose we have a project with single .tex file. The allDependencies() returns empty list. At least it was in my tests. This is not correct, do you agree? Master document must be included in time checks. That is why I was adding source(). Am I right?
'Info::lastModifiedFile' will always consider its own time stamp as well; so, there's no need to add it to the dependencies list.
On September 27th, 2012, 8:37 p.m., Eugene Shalygin wrote:
Review request for Kile and Michel Ludwig.
By Eugene Shalygin.
Updated Sept. 27, 2012, 8:37 p.m.