This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106213/

Yes, please remove the changes to 'kile3.0-1.upd.pl' and also to CMakeLists.txt. Other than that, there are still a few minor indentation issues.

Do you have a git account to commit the patch?

src/kilestdtools.cpp (Diff revision 2)
namespace KileTool
253
		if (QString::compare(requestedTool,"bibtex",Qt::CaseInsensitive) == 0){
Can you add a space after the comma (each time and also below)?

src/kilestdtools.cpp (Diff revision 2)
namespace KileTool
285
					   m_latexOutputInfoList[i].message().contains("Rerun", Qt::CaseInsensitive)) {
Can you align 'm_latexOutputInfoList' with 'm_latexOutputInfoList' above using spaces? (see below)

src/kilestdtools.cpp (Diff revision 2)
namespace KileTool
297
					   biblatexBackendMessage.indexIn(m_latexOutputInfoList[i].message()) != -1) {
Can you align 'biblatexBackendMessage' with 'm_latexOutputInfoList' using spaces after the last tab (reaching the indentation level of 'if')?

src/kilestdtools.cpp (Diff revision 2)
namespace KileTool
299
				KILE_DEBUG() << "Captured Bib tool: " << bibToolInLaTexOutput;
This seems to be indented wrongly.

src/latexcmd.h (Diff revision 2)
class LatexCmdAttributes
44
class LatexCmdAttributes 
45
class LatexCmdAttributes 
Can you remove this superfluous whitespace?

src/latexcmd.cpp (Diff revision 2)
QChar LatexCommands::getAttrChar(CmdAttribute attr)
263
	
269
	
Can you remove this superfluous whitespace?

src/latexcmd.cpp (Diff revision 2)
CmdAttribute LatexCommands::getCharAttr(QChar ch)
303
	
312
	
Can you remove this superfluous whitespace?

- Michel


On August 27th, 2012, 5:10 p.m., Eugene Shalygin wrote:

Review request for Kile.
By Eugene Shalygin.

Updated Aug. 27, 2012, 5:10 p.m.

Description

Three things have to be done for that:
1. Detect biblatex backend and run appropriate tool
2. Fix LaTeX rerun 
3. Detect bibliography resources in new commands

For item 1 we add Add BibTex/Biber tool. Then we capture bibtool name from LaTeX output and try to load bib tools
with the same configuration. If it is not possible, load user default one

For item 2 one needs just to look for "rerun" instead of "Rerun" in the latex output. Solved by adding option Qt::CaseInsensitive in src/kilestdtools.cpp.

For item 3 the follwing soltion is proposed. Add a section "Bibliographies" to latex commands configuration where 4 default commands are provied: \bibliography, \addbibresource, \addglobalbib, and \addsectionbib. These commands are taken for parsing and \bibliography item is removed from static list items in  src/documentinfo.cpp. 

Testing

Manual testing by compiling in nornal and LivePreview modes with PDFLaTeX and XeLaTeX specifying different Biblatex backends.
Bugs: 268047

Diffs

  • CMakeLists.txt (7191069)
  • kile3.0-1.upd.pl (PRE-CREATION)
  • src/data/kilestdtools-win.rc (182cb5d)
  • src/data/kilestdtools.rc (cfdadca)
  • src/dialogs/latexcommanddialog.h (c19f659)
  • src/dialogs/latexcommanddialog.cpp (1dc6ebe)
  • src/documentinfo.cpp (2034142)
  • src/kilestdtools.h (0ad2b7f)
  • src/kilestdtools.cpp (012f55f)
  • src/latexcmd.h (c504aec)
  • src/latexcmd.cpp (1f46fdc)

View Diff