Re: [Kgdb-bugreport] CFI macros for KGDB

[Tom R. <tr...@ke...>]

On Fri, Jan 06, 2006 at 08:43:17PM +0530, Amit Kale wrote:
> On Friday 06 Jan 2006 8:30 pm, Tom Rini wrote:
> > On Fri, Jan 06, 2006 at 03:27:21PM +0530, Milind Dumbare wrote:
> > > Patch attached provides CFI macros for KGDB.
> > >
> > > I have put an option in lib/Kconfig.debug for enabling it. By default
> > > its off. Those CFI macros are useful when GAS is above version 2.15.
> >
> > I can see the .foo -> .Lfoo being a deal breaker unless we can explain
> > exactly why this must be done, and why it can't at least be hidden away
> >
> > somehow.  Also:
> 
> I should have sent an email explaining this: Labels of the form .Lfoo don't 
> appear in global symbols, so gdb isn't confused by them. At present every 
> label in entry.S appears at global level. By limiting the number of labels 
> that appear globally, we can add function start and end information.

Right, but it's something that every new label put in there is going to
have to know.  If we must, really must, do this, it needs to be a macro
with a comment above it saying why.

> > But I think we should always do this on KGDB and try and use one of the
> > version check Makefile magic bits to determine if they have sufficient
> > binutils or not.
> 
> I don't know whether it's possible or not. We'll try to find a way to do that.

At worst, a version check and a -DHAS_BINUTILS_215 or something should
do.

-- 
Tom Rini
http://gate.crashing.org/~trini/