Menu

#5 Broken default delay_loop value

open
nobody
None
5
2008-01-23
2008-01-23
Anonymous
No

Default delay_loop probably miss some multiplication by TIMER_HZ; So services with no delay_loop specified are checked much more often than expected.

Sources:
----------
check_parser.c:
delay_handler(vector strvec)
{
virtual_server *vs = LIST_TAIL_DATA(check_data->vs);
vs->delay_loop = atoi(VECTOR_SLOT(strvec, 1)) * TIMER_HZ;
}

check_data.c:
new->delay_loop = KEEPALIVED_DEFAULT_DELAY;

check_data.h:
#define KEEPALIVED_DEFAULT_DELAY 60
----------

Should be
#define KEEPALIVED_DEFAULT_DELAY (60 * TIMER_HZ)
?

Discussion


Log in to post a comment.