#93 linux test failures

[Bud Davis]

Version f26838b57372a5da4a9c259aeadc630e05bcf346, roughly 1 Dec 2018, has the below test failures:

[bdavis@localhost build]$ uname -a
Linux localhost.localdomain 4.19.2-200.fc28.x86_64 #1 SMP Wed Nov 14 20:58:35 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
[bdavis@localhost build]$ g++ --version
g++ (GCC) 8.2.1 20181105 (Red Hat 8.2.1-5)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

clean c

----------] 2 tests from EncodeDecodeTest/9, where TypeParam = KDIS::PDU::Appearance_PDU
[ RUN ] EncodeDecodeTest/9.PDU_EncodeDecode6
/home/bdavis/kdis-code/KDIS/Tests/UnitTests/PDU_EncodeDecode6.cpp:62: Failure
Value of: pduOut
Actual: 200-byte object <60-0B 8C-00 00-00 00-00 06-00 2F-0B 00-00 00-00 88-25 89-00 00-00 00-00 00-00 00-00 00-7F 00-00 11-00 00-00 FC-7F 00-00 98-D4 89-00 00-00 00-00 00-00 00-00 FC-7F 00-00 00-00 70-02 00-00 00-00 ... D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 0C-7F 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 0C-7F 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00>
Expected: pduIn
Which is: 200-byte object <60-0B 8C-00 00-00 00-00 06-00 2F-0B 00-00 00-00 88-25 89-00 00-00 00-00 00-00 00-00 00-00 00-00 11-00 00-00 FC-7F 00-00 98-D4 89-00 00-00 00-00 00-00 00-00 30-00 00-00 00-00 D5-E9 FC-7F 00-00 ... D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00>
[ FAILED ] EncodeDecodeTest/9.PDU_EncodeDecode6, where TypeParam = KDIS::PDU::Appearance_PDU (0 ms)
[ RUN ] EncodeDecodeTest/9.PDU_EncodeDecode6_IgnoreHeader
/home/bdavis/kdis-code/KDIS/Tests/UnitTests/PDU_EncodeDecode6.cpp:73: Failure
Value of: pduOut
Actual: 200-byte object <60-0B 8C-00 00-00 00-00 06-00 2F-0B 00-00 00-00 88-25 89-00 00-00 00-00 00-00 00-00 00-00 00-00 11-00 00-00 00-00 00-00 98-D4 89-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 2F-0B 00-00 00-00 ... D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00>
Expected: pduIn
Which is: 200-byte object <60-0B 8C-00 00-00 00-00 06-00 2F-0B 00-00 00-00 88-25 89-00 00-00 00-00 00-00 00-00 00-00 00-00 11-00 00-00 FC-7F 00-00 98-D4 89-00 00-00 00-00 00-00 00-00 30-00 00-00 00-00 D5-E9 FC-7F 00-00 ... D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00 D8-D7 88-00 00-00 00-00 00-00 00-00 00-00 00-00>
[ FAILED ] EncodeDecodeTest/9.PDU_EncodeDecode6_IgnoreHeader, where TypeParam = KDIS::PDU::Appearance_PDU (0 ms)

[Bud Davis]

patch that fixes the above failures. it could also be fixed by initialization, let me know if you would rather I go down that path.

--bud

diff --git a/KDIS/KDIS/PDU/Live_Entity/Appearance_PDU.cpp b/KDIS/KDIS/PDU/Live_Entity/Appearance_PDU.cpp
index 5a5b551..df3fc9f 100644
--- a/KDIS/KDIS/PDU/Live_Entity/Appearance_PDU.cpp
+++ b/KDIS/KDIS/PDU/Live_Entity/Appearance_PDU.cpp
@@ -749,15 +749,15 @@ KBOOL Appearance_PDU::operator == ( const Appearance_PDU & Value ) const
if( LE_Header::operator != ( Value ) ) return false;
if( m_AppearanceFlag1Union.m_ui8Flag != Value.m_AppearanceFlag1Union.m_ui8Flag ) return false;
if( m_AppearanceFlag2Union.m_ui8Flag != Value.m_AppearanceFlag2Union.m_ui8Flag ) return false;

• if( m_ui8ForceID != Value.m_ui8ForceID ) return false;
• if( m_EntityType != Value.m_EntityType ) return false;
• if( m_AltEntityType != Value.m_AltEntityType ) return false;
• if( m_EntityMarking != Value.m_EntityMarking ) return false;
• if( m_EntityCapabilities != Value.m_EntityCapabilities ) return false;
• if( m_VisApp != Value.m_VisApp ) return false;
• if( m_IRApp != Value.m_IRApp ) return false;
• if( m_EMApp != Value.m_EMApp ) return false;
• if( m_AudApp != Value.m_AudApp ) return false;
• if( m_AppearanceFlag1Union.m_ui8ForceId && m_ui8ForceID != Value.m_ui8ForceID ) return false;
• if( m_AppearanceFlag1Union.m_ui8Typ && m_EntityType != Value.m_EntityType ) return false;
• if( m_AppearanceFlag1Union.m_ui8AltTyp && m_AltEntityType != Value.m_AltEntityType ) return false;
• if( m_AppearanceFlag1Union.m_ui8Mark && m_EntityMarking != Value.m_EntityMarking ) return false;
• if( m_AppearanceFlag1Union.m_ui8Cap && m_EntityCapabilities != Value.m_EntityCapabilities ) return false;
• if( m_AppearanceFlag1Union.m_ui8Vis && m_VisApp != Value.m_VisApp ) return false;
• if( m_AppearanceFlag1Union.m_ui8IR && m_IRApp != Value.m_IRApp ) return false;
• if( m_AppearanceFlag2Union.m_ui8EM && m_EMApp != Value.m_EMApp ) return false;
• if( m_AppearanceFlag2Union.m_ui8Audio && m_AudApp != Value.m_AudApp ) return false;
  return true;
  }

[Gerard Lanois]

Fixed by https://sourceforge.net/p/kdis/bugs/99/ - Can close?

[Karl Jones]

Thanks!