#16 Fails to compile with Qt 4.8.5
FAILED: /usr/lib/ccache/c++ -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=26 -DKDE_DEPRECATED_WARNINGS -DQT_NO_CAST_TO_ASCII -DQT_NO_STL -D_BSD_SOURCE -D_REENTRANT -D_XOPEN_SOURCE=500 -Wnon-virtual-dtor -Wno-long-long -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -g -O2 -fno-reorder-blocks -fno-schedule-insns -fno-inline -I/home/krf/devel/install/master/include -I/home/krf/devel/build/qt4.8-shared-debug/include/QtXmlPatterns -I/home/krf/devel/build/qt4.8-shared-debug/include/QtXml -I/home/krf/devel/build/qt4.8-shared-debug/include/QtWebKit -I/home/krf/devel/build/qt4.8-shared-debug/include/QtUiTools -I/home/krf/devel/build/qt4.8-shared-debug/include/QtTest -I/home/krf/devel/build/qt4.8-shared-debug/include/QtSvg -I/home/krf/devel/build/qt4.8-shared-debug/include/QtSql -I/home/krf/devel/build/qt4.8-shared-debug/include/QtScriptTools -I/home/krf/devel/build/qt4.8-shared-debug/include/QtScript -I/home/krf/devel/build/qt4.8-shared-debug/include/QtOpenGL -I/home/krf/devel/build/qt4.8-shared-debug/include/QtNetwork -I/home/krf/devel/build/qt4.8-shared-debug/include/QtMultimedia -I/home/krf/devel/build/qt4.8-shared-debug/include/QtHelp -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDesigner -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDeclarative -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDBus -I/home/krf/devel/build/qt4.8-shared-debug/include/Qt3Support -I/home/krf/devel/build/qt4.8-shared-debug/include/QtGui -I/home/krf/devel/build/qt4.8-shared-debug/include/QtCore -I/home/krf/devel/build/qt4.8-shared-debug/include/Qt -I/home/krf/devel/build/qt4.8-shared-debug/mkspecs/default -I/home/krf/devel/build/qt4.8-shared-debug/include -I. -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -MMD -MT src-QT4/CMakeFiles/kdiff3.dir/progress.o -MF "src-QT4/CMakeFiles/kdiff3.dir/progress.o.d" -o src-QT4/CMakeFiles/kdiff3.dir/progress.o -c /home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp: In constructor 'ProgressDialog::ProgressDialog(QWidget*)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp:27:19: error: incomplete type 'QThread' used in nested name specifier
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp: In member function 'void ProgressDialog::recalc(bool)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp:233:9: error: incomplete type 'QThread' used in nested name specifier
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp: In member function 'bool ProgressDialog::wasCancelled()':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/progress.cpp:322:9: error: incomplete type 'QThread' used in nested name specifier
and:
FAILED: /usr/lib/ccache/c++ -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=26 -DKDE_DEPRECATED_WARNINGS -DQT_NO_CAST_TO_ASCII -DQT_NO_STL -D_BSD_SOURCE -D_REENTRANT -D_XOPEN_SOURCE=500 -Wnon-virtual-dtor -Wno-long-long -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -g -O2 -fno-reorder-blocks -fno-schedule-insns -fno-inline -I/home/krf/devel/install/master/include -I/home/krf/devel/build/qt4.8-shared-debug/include/QtXmlPatterns -I/home/krf/devel/build/qt4.8-shared-debug/include/QtXml -I/home/krf/devel/build/qt4.8-shared-debug/include/QtWebKit -I/home/krf/devel/build/qt4.8-shared-debug/include/QtUiTools -I/home/krf/devel/build/qt4.8-shared-debug/include/QtTest -I/home/krf/devel/build/qt4.8-shared-debug/include/QtSvg -I/home/krf/devel/build/qt4.8-shared-debug/include/QtSql -I/home/krf/devel/build/qt4.8-shared-debug/include/QtScriptTools -I/home/krf/devel/build/qt4.8-shared-debug/include/QtScript -I/home/krf/devel/build/qt4.8-shared-debug/include/QtOpenGL -I/home/krf/devel/build/qt4.8-shared-debug/include/QtNetwork -I/home/krf/devel/build/qt4.8-shared-debug/include/QtMultimedia -I/home/krf/devel/build/qt4.8-shared-debug/include/QtHelp -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDesigner -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDeclarative -I/home/krf/devel/build/qt4.8-shared-debug/include/QtDBus -I/home/krf/devel/build/qt4.8-shared-debug/include/Qt3Support -I/home/krf/devel/build/qt4.8-shared-debug/include/QtGui -I/home/krf/devel/build/qt4.8-shared-debug/include/QtCore -I/home/krf/devel/build/qt4.8-shared-debug/include/Qt -I/home/krf/devel/build/qt4.8-shared-debug/mkspecs/default -I/home/krf/devel/build/qt4.8-shared-debug/include -I. -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -MMD -MT src-QT4/CMakeFiles/kdiff3.dir/difftextwindow.o -MF "src-QT4/CMakeFiles/kdiff3.dir/difftextwindow.o.d" -o src-QT4/CMakeFiles/kdiff3.dir/difftextwindow.o -c /home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:946:15: warning: multi-character character constant [-Wmultichar]
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp: In member function 'void DiffTextWindowData::prepareTextLayout(QTextLayout&, bool, int)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:804:6: warning: parameter 'bFirstLine' set but not used [-Wunused-but-set-parameter]
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp: At global scope:
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:1539:1: error: expected class-name before '{' token
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp: In constructor 'RecalcWordWrapRunnable::RecalcWordWrapRunnable(DiffTextWindow, int, int, ProgressProxy)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:1548:25: error: 'setAutoDelete' was not declared in this scope
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp: In member function 'void DiffTextWindow::recalcWordWrap(bool, int, int, ProgressProxy)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:1585:10: error: 'QThreadPool' has not been declared
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp: In member function 'void DiffTextWindow::recalcWordWrapHelper(bool, int, int, int, ProgressProxy)':
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:1643:40: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
/home/krf/devel/src/kdiff3/kdiff3/src-QT4/difftextwindow.cpp:1607:11: warning: unused variable 'wrapLineCacheIdx' [-Wunused-variable]
Patch:
Should be committed. I ended up reproducing exactly the same patch.