#183 kdiff3-0.9.97/src-QT4/directorymergewindow.cpp:3484]: (style) Same expression on both sides of '&&'.

v1.0_(example)
open
nobody
None
1
2014-02-08
2014-02-08
dcb
No

Source code is

d->m_pDirCurrentSyncDeleteAAndB->setEnabled( bItemActive && !bMergeMode && pMFI->existsInB() && pMFI->existsInB() );

Maybe

d->m_pDirCurrentSyncDeleteAAndB->setEnabled( bItemActive && !bMergeMode && pMFI->existsInA() && pMFI->existsInB() );

would be better code. I found this bug in the current code using
static analyser cppcheck.

Discussion


Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks