From: Jean-Baptiste M. <jb...@kd...> - 2012-09-02 09:41:43
|
Git commit 7536d25117a35307e66da80fc3df204d23433f07 by Jean-Baptiste Mardelle, on behalf of Mikko Rapeli. Committed on 10/08/2012 at 14:17. Pushed by mardelle into branch 'master'. projectsettings.cpp: return if open() fails Fixes Coverity CID 709281: Unchecked return value (CHECKED_RETURN) Calling function "QFile::open(QFlags<QIODevice::OpenModeFlag>)" without checking return value (as is done elsewhere 45 out of 47 times). No check of the return value of "xmlf.open(QIODevice::OpenMode(_ZN9QIODevice9WriteOnlyE))". 552 xmlf.open(QIODevice::WriteOnly); M +2 -1 src/projectsettings.cpp http://commits.kde.org/kdenlive/7536d25117a35307e66da80fc3df204d23433f07 diff --git a/src/projectsettings.cpp b/src/projectsettings.cpp index ba8aebf..9289e18 100644 --- a/src/projectsettings.cpp +++ b/src/projectsettings.cpp @@ -549,7 +549,8 @@ void ProjectSettings::slotExportToText() return; } QFile xmlf(tmpfile.fileName()); - xmlf.open(QIODevice::WriteOnly); + if (!xmlf.open(QIODevice::WriteOnly)) + return; xmlf.write(data.toUtf8()); if (xmlf.error() != QFile::NoError) { xmlf.close(); |