From: Mikko R. <mik...@ik...> - 2011-09-28 19:49:32
|
Should fix valgrind warning: Conditional jump or move depends on uninitialised value(s) at 0x811D1FD: KdenliveDoc::setProfilePath(QString) (kdenlivedoc.cpp:871) --- src/kdenlivedoc.cpp | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp index 8b7a13e..157ad23 100644 --- a/src/kdenlivedoc.cpp +++ b/src/kdenlivedoc.cpp @@ -68,6 +68,18 @@ KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup m_modified(false), m_projectFolder(projectFolder) { + // init m_profile struct + m_profile.frame_rate_num = 0; + m_profile.frame_rate_den = 0; + m_profile.width = 0; + m_profile.height = 0; + m_profile.progressive = 0; + m_profile.sample_aspect_num = 0; + m_profile.sample_aspect_den = 0; + m_profile.display_aspect_num = 0; + m_profile.display_aspect_den = 0; + m_profile.colorspace = 0; + m_clipManager = new ClipManager(this); m_autoSaveTimer = new QTimer(this); m_autoSaveTimer->setSingleShot(true); -- 1.7.5.4 |
From: Mikko R. <mik...@ik...> - 2011-09-28 19:50:19
|
Clips in project list with subclips have no visual indicator that they have subclips so expand them by default. Better fix would be to add a clear visual indicator to clips with subclips, for example clips in a folder already have this. --- src/subprojectitem.cpp | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/subprojectitem.cpp b/src/subprojectitem.cpp index 9c8ad1e..d397804 100644 --- a/src/subprojectitem.cpp +++ b/src/subprojectitem.cpp @@ -40,6 +40,11 @@ SubProjectItem::SubProjectItem(QTreeWidgetItem * parent, int in, int out, QStrin setText(1, description); GenTime duration = GenTime(out - in, KdenliveSettings::project_fps()); if (duration != GenTime()) setData(0, DurationRole, Timecode::getEasyTimecode(duration, KdenliveSettings::project_fps())); + + // Expand and show all subclips by default instead of hiding them. + if (parent && !parent->isExpanded()) + parent->setExpanded(true); + //setFlags(Qt::NoItemFlags); //kDebug() << "Constructed with clipId: " << m_clipId; } -- 1.7.5.4 |
From: Simon A. E. <sim...@gm...> - 2011-10-19 16:32:10
|
Has this patch been applied? On 09/28/2011 09:40 PM, Mikko Rapeli wrote: > Clips in project list with subclips have no visual indicator that > they have subclips so expand them by default. > > Better fix would be to add a clear visual indicator to clips with subclips, > for example clips in a folder already have this. > --- > src/subprojectitem.cpp | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/src/subprojectitem.cpp b/src/subprojectitem.cpp > index 9c8ad1e..d397804 100644 > --- a/src/subprojectitem.cpp > +++ b/src/subprojectitem.cpp > @@ -40,6 +40,11 @@ SubProjectItem::SubProjectItem(QTreeWidgetItem * parent, int in, int out, QStrin > setText(1, description); > GenTime duration = GenTime(out - in, KdenliveSettings::project_fps()); > if (duration != GenTime()) setData(0, DurationRole, Timecode::getEasyTimecode(duration, KdenliveSettings::project_fps())); > + > + // Expand and show all subclips by default instead of hiding them. > + if (parent&& !parent->isExpanded()) > + parent->setExpanded(true); > + > //setFlags(Qt::NoItemFlags); > //kDebug()<< "Constructed with clipId: "<< m_clipId; > } |
From: Mikko R. <mik...@ik...> - 2011-10-19 16:48:48
|
On Wed, Oct 19, 2011 at 06:31:57PM +0200, Simon A. Eugster wrote: > Has this patch been applied? No, but the issue has been fixed. The GUI now shows an indicator if clip has subclips. -Mikko |
From: jb <jb...@kd...> - 2011-10-19 16:46:33
|
On Wednesday 19 October 2011 18:31:57 Simon A. Eugster wrote: > Has this patch been applied? > > On 09/28/2011 09:40 PM, Mikko Rapeli wrote: > > Clips in project list with subclips have no visual indicator that > > they have subclips so expand them by default. > > > > Better fix would be to add a clear visual indicator to clips with > > subclips, for example clips in a folder already have this. I did not apply this patch but fixed the issue as suggested in the last part of this mail: we now display a visual indicator - a triangle - to show that a clip has children... regards jb |
From: Simon A. E. <sim...@gm...> - 2011-10-19 17:29:38
|
On 10/19/2011 06:43 PM, jb wrote: > On Wednesday 19 October 2011 18:31:57 Simon A. Eugster wrote: >> Has this patch been applied? >> >> On 09/28/2011 09:40 PM, Mikko Rapeli wrote: >>> Clips in project list with subclips have no visual indicator that >>> they have subclips so expand them by default. >>> >>> Better fix would be to add a clear visual indicator to clips with >>> subclips, for example clips in a folder already have this. > > I did not apply this patch but fixed the issue as suggested in the last part of > this mail: we now display a visual indicator - a triangle - to show that a > clip has children... Ah, okay, thanks. Great :) Simon |
From: jb <jb...@kd...> - 2011-09-29 13:57:36
|
On Wednesday 28 September 2011 22:39:38 Mikko Rapeli wrote: > Should fix valgrind warning: > > Conditional jump or move depends on uninitialised value(s) > at 0x811D1FD: KdenliveDoc::setProfilePath(QString) (kdenlivedoc.cpp:871) Applied, thanks jb |