Re: [Kaldi-developers] error code when scoring fails

[Daniel P. <dp...@gm...>]

Hm.
I notice that all the decoding scripts are like this, they don't check
the return status.
I'm not sure what to do about this- cc'ing kaldi-developers to get
more opinions.
There might be some setups where people want to decode but they
haven't finished the scoring scripts, but on the other hand it would
be more consistent to check the return status.

Dan


On Wed, Jul 1, 2015 at 8:47 AM, Jan Trmal <jt...@gm...> wrote:
> I think it should fail, preferably using "|| exit 1" as the wsj scripts are
> written in that way. If the user doesn't want the decode* scripts to fail
> because of (expected) failure in scoring he/she can call the decode* scripts
> with "--skip-scoring true". But I think we should wait for Dan to decide.
>
> BTW, I'm suggesting "||exit 1" also because I tried using "set -e" a while
> ago and it definitely didn't work out of the box.
>
> y.
>
> On Wed, Jul 1, 2015 at 7:41 AM, Karel Veselý <ve...@gm...> wrote:
>>
>> Hi Dan, Yenda,
>> as I am polishing and running the AMI recipes for the workshop, I've
>> noticed one thing.
>> If I decode with 'steps/decode.sh' and the scoring fails, the script
>> 'steps/decode.sh' still
>> finishes with error code 0.
>>
>> My question is, is this a bug or a feature? :)
>>
>> I would naturally expect that the the error gets propagated, so that it
>> stops the master script.
>>
>> I.e. the change would be:
>> => Option 1: adding '||exit 1' in steps/decode.sh:  "local/score.sh --cmd
>> "$cmd" $scoring_opts $data $graphdir $dir || exit 1"
>> => Options 2: or, by adding 'set -e' somewhere into steps/decode.sh
>>
>> The scoring error is ignored almost all the scripts: steps/decode*.sh
>>
>> Can you please comment?
>> Cheers!
>> Karel.
>
>