[Kaldi-developers] Changes in src/gst-plugin/Makefile

[Niranjan V. <nvi...@gm...>]

Hello,

I am new to kaldi. I am at revision 5112.

I had to make following changes to src/gst-plugin/Makefile -
in line 9 and 10, add "--libs" flag.
for eg.

  9 EXTRA_CXXFLAGS += $(shell pkg-config --cflags *--libs *gstreamer-1.0)
 10 EXTRA_CXXFLAGS += $(shell pkg-config --cflags* --libs *glib-2.0)

and I had to include $(EXTRA_CXXFLAGS) in the rule corresponding to
$(LIBFILE) at line no. 41.
For eg.

 41 $(LIBFILE): $(OBJFILES)
 42         $(CXX) -shared -DPIC -o $(LIBFILE) -Wl,-soname=$(LIBFILE)
-Wl,--no-as-needed \
 43           -L$(KALDILIBDIR) -Wl,-rpath=$(KALDILIBDIR) $(EXTRA_LDLIBS)
$(LDLIBS) $(LDFLAGS) *$(EXTRA_CXXFLAGS)* \
 44           $(OBJFILES)


Before these changes, "make" was failing as it could not find gst specific
plugins from $(EXTRA_LDLIBS).
(I have gstreamer and glib installed in local area as I don't have a root
access on my system)

Are these changes correct?
If yes, they can be included in Makefile.
If not, then what is correct way of building gstreamer without
modifications to the Makefile.

Thanks in advance,
Niranjan.