Re: [Kaldi-developers] Windows patches to src/ (mostly)

[Jan T. <jt...@gm...>]

Kirill,
thanks for your work and patches. I mostly like those patches. However, I
have expressed the concern about several things. I will summarize the
concerns here. Those interested in details, please go to the github
discussion. Also, please feel free to comment on the patches. I think
reviewing patches and reading them is a great way how to start with kaldi
development
a) we should figure out what versions of MSVC we plan to "support'. For
example stdint.h is either not supported at all or supported only in the
most recent versions of the compiler. We should issue compile-time
warning/error if the version of compiler (probably value of _MSC_VER) is
not supported
b) I'm hesitant to accept your stance "we are relying on cygwin". Cygwin
will be definitely necessary for running the egs, but kaldi development and
especially development using kaldi libs should not rely on cygwin. We
should facilitate developement of "clean" windows applications without
needing cygwin runtime to be installed. I actually think it would be nice
of someone would be willing to contribute some windows example (I'm
thinking of voxforge or yesno) -- either in powershell) or a GUI app, that
could take files from kaldi-asr.org and decode a wav or a online speech
from a microphone.

I don;t mean to sound too negative --but I feel we (kaldi community) should
discuss these thing and decide. All being said, I think the patches are
good job.
y.

y.


y.

On Tue, May 19, 2015 at 5:59 AM, Kirill Katsnelson <
kir...@sm...> wrote:

> > Actually on second thoughts, there would be no point fixing this as a
> > patch, because patches anyway can't be applied from Windows unless you
> > have cygwin installed, which I guess we're not assuming.
>
> Just to set things straight, we definitely are relying on cygwin. Bash is
> kaldi's glue in all recipes, and there is not much use for it without
> Cygwin.
>
> The main impetus behind the port was the support of CUDA and Intel MKL.
> Also, I thought that the use of Intel compiler would speed it up on latest
> Intel's CPUs, but it did not help much in practice over MSVC--perhaps
> because most of matrix code is converted into BLAS calls already.
>
> I am going to repro the original compiler's errors tonight.
>
>  -kkm
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Kaldi-developers mailing list
> Kal...@li...
> https://lists.sourceforge.net/lists/listinfo/kaldi-developers
>