Re: [Kaldi-developers] [Kaldi-users] Kaldi compiles now under VS 2013

[Daniel P. <dp...@gm...>]

>> To the extent that your patches are simple fixes and minor changes to
>> the code, I think we could apply them.  Perhaps you could work with
>> Yenda to get your changes checked?
>
> Easy enough, and as easy to hold till the migration is done. Was there a change in the plans?

Not really a change in the plans, but we don't have a definite
timeline for migrating to git, and it could be that we'll keep the svn
as upstream for a while.  Your changes seem reasonable, but I think it
would be better to get things started now rather than later.  The
git/svn issues should not be that hard.  Just start sending patches to
Yenda and we'll handle your changes bit by bit.
Dan


>
>> If you update your git repo to
>> point to the current code, then a patch should be applicable by the
>> program "patch" to the svn repo too.
>
> There are many changes, and I certainly want to split the patch so it is readable. One megapatch is not reviewable.
>
>> Regarding your build approach, you could send me and Yenda some details
>> about how you did it, and we could consider whether to support that.
>
> There's a Powershell script that takes information from every src/*/Makefile into a simple declarative MSBuild script $dirname.kwproj, and a top-level MSBuild "makefile" that drives the whole thing. A little bit more complex than that to allow for user-defined options, but generally this is it. This supports building libraries, tools, tests and running the tests with command line switches. The whole thing pretty much mimics a linux make process but using MS tools.
>
>> I don't think it makes sense to try to maintain a parallel "windows-
>> compatible" version of the scripts, if there are larger changes
>> required there.
>
> I was targeting for no changes at all. There maybe a few very small patches that supposed not to break compatibility.
>
>> Anyway you depend on cygwin for scripting, and the set
>> of people who want to run cygwin and build with MSVC is probably
>> limited enough that I don't think it makes sense for us to try to
>> support it.
>
> This is not as simple a choice as it seems at first. Alex Hung just posted a trick to build CUDA under Cygwin; before he did I thought it was not possible. MKL is another story. I would rather build under native Windows than try to pull this monster into the Cygwin build environment.
>
>  -kkm
>