Re: [Kaldi-developers] A fix to the use of a nonstandard awk extension and a missing error check after it

[Vesely K. <ive...@fi...>]

Hi Kirill, Dan,
thanks for fixing the issue and letting me know.

I think the easiest solution to the original problem was to simply replace
'gensub' by 'gsub' or 'sub', which is available in all the versions of awk.

The perl fix is also fine...
Thanks,
Karel.

On 05/02/2015 07:10 AM, Daniel Povey wrote:
> Hi,
> Thanks for the patch.
> Unfortunately your patch brings up another compatibility problem: it 
> looks like the BSD-style 'sed' that is available on Mac does not 
> recognize the \0.  Instead I used a perl expression (perl is always 
> compatible across systems).
>  perl -ape 's:.*/([^/]+)\.gz$:$1 gunzip -c $& |:; '
> I committed this.
> Karel, I have tested the expression but not the whole script.
> I also made it use an absolute pathname in the .scp file, which is 
> always recommended.
> Dan
>
>
> On Fri, May 1, 2015 at 8:37 PM, Kirill Katsnelson 
> <kir...@sm... 
> <mailto:kir...@sm...>> wrote:
>
>     > -----Original Message-----
>     > From: Kirill Katsnelson
>     [mailto:kir...@sm...
>     <mailto:kir...@sm...>]
>     > Sent: 2015-05-01 1733
>     >
>     > Here's a small patch to make_denlats.sh. My awk does not have a
>     > function gensub() (Ubuntu 14.04 packages gawk separately from awk!),
>     > and because of that the generated lat.scp was empty. Compounding the
>     > problem, mpe training happily proceeded, even though missing
>     lattices
>     > for every utterance. Took me a while to track back.
>     >
>     > I have changed the code to use sed and to fail if the generated
>     scp has
>     > a zero length.
>     [kkm]
>
>     Ah, and the sort. My find(1) finds files quite out of order, maybe
>     because of ext4?
>
>     $ find dnn4_pretrain-dbn_dnn_denlats/lat1 -name '*.gz' | head -3
>     dnn4_pretrain-dbn_dnn_denlats/lat1/41/BertrandPiccard_2009G-0097823-0098802.gz
>     dnn4_pretrain-dbn_dnn_denlats/lat1/41/BernieKrause_2013G-0047540-0048091.gz
>     dnn4_pretrain-dbn_dnn_denlats/lat1/41/BethNoveck_2012G-0024724-0026655.gz
>
>     I do not know if sorted promise is used on the lat.scp later, so I
>     sorted it just in case. May not be really required.
>
>      -kkm
>
>
>
>
>     ------------------------------------------------------------------------------
>     One dashboard for servers and applications across
>     Physical-Virtual-Cloud
>     Widest out-of-the-box monitoring support with 50+ applications
>     Performance metrics, stats and reports that give you Actionable
>     Insights
>     Deep dive visibility with transaction tracing using APM Insight.
>     http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>     _______________________________________________
>     Kaldi-developers mailing list
>     Kal...@li...
>     <mailto:Kal...@li...>
>     https://lists.sourceforge.net/lists/listinfo/kaldi-developers
>
>

-- 
Karel Vesely, Brno University of Technology
ive...@fi..., +420-54114-1300