Menu ▾ ▴

Possible typo in kaldi-trunk/src/gst-plugin/Makefile

Developers
CCorfield
2015-05-31
2015-06-01

  • CCorfield

    CCorfield - 2015-05-31

    In the gstreamer-plugin Makefile, the first assignment to EXTRA_CXXFLAGS looks like it should read "+=" so that it can add to the settings inherited from ../kaldi.mk.

    all:
    include ../kaldi.mk
    ifneq ($(KALDI_FLAVOR), dynamic)
    $(error Kaldi must compiled with dynamic libraries support. Run configure with --shared flag. )
    endif
    EXTRA_CXXFLAGS = -Wno-sign-compare -I ../../tools/portaudio/install/include
    EXTRA_CXXFLAGS += $(shell pkg-config --cflags gstreamer-1.0)
    EXTRA_CXXFLAGS += $(shell pkg-config --cflags glib-2.0)

     

    • Daniel Povey

      Daniel Povey - 2015-06-01

      OK.
      Tanel, if this is right, could you please fix this?
      Dan

      On Sun, May 31, 2015 at 12:44 PM, CCorfield ccorfield@users.sf.net wrote:

      In the gstreamer-plugin Makefile, the first assignment to EXTRA_CXXFLAGS
      looks like it should read "+=" so that it can add to the settings inherited
      from ../kaldi.mk.

      all:
      include ../kaldi.mk
      ifneq ($(KALDI_FLAVOR), dynamic)
      $(error Kaldi must compiled with dynamic libraries support. Run configure
      with --shared flag. )
      endif
      EXTRA_CXXFLAGS = -Wno-sign-compare -I ../../tools/portaudio/install/include
      EXTRA_CXXFLAGS += $(shell pkg-config --cflags gstreamer-1.0)
      EXTRA_CXXFLAGS += $(shell pkg-config --cflags glib-2.0)

      Possible typo in kaldi-trunk/src/gst-plugin/Makefile

      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/kaldi/discussion/1355349/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

  • Tanel Alumäe

    Tanel Alumäe - 2015-06-01

    Fixed. Also inherited EXTRA_LDLIBS.