|
From: David B. <dc...@ho...> - 2013-10-04 10:35:51
|
Hello there,
I just ran static analyser "cppcheck" over the source code of kaffeine-1.2.2
It said
kaffeine-1.2.2/src/backend-xine/xineapplication.cpp:341]: (warning) Logical disjunction always evaluates to true: pixelAspectRatio>= 0.96 || pixelAspectRatio <= 1.04.
Source code is
if ((pixelAspectRatio>= 0.96) || (pixelAspectRatio <= 1.04)) {
pixelAspectRatio = 1;
}
Suggest swap || for &&
Regards
David Binderman
|
