Thread: [kaffeine-user] Review Request: in Kcmdlineargs, no-<whatever> is now a normal option
Brought to you by:
hftom,
lasselindqvist
From: Jaime T. <jt...@gm...> - 2010-10-16 10:41:01
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5637/ ----------------------------------------------------------- Review request for kaffeine. Summary ------- I need an option called no-label followed by some text. With this simple change, no- is not an special prefix, so anything that stars with no- is a normal option. Also changed the documentation in the header. Diffs ----- /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.h 1186293 /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp 1186293 Diff: http://svn.reviewboard.kde.org/r/5637/diff Testing ------- made make test in kdelibs build root, previous results here: 1 - nepomuk-queryparsertest (Failed) 2 - nepomuk-querytest (Failed) 4 - nepomuk-resourcetest (Failed) 11 - kdecore-kstandarddirstest (Failed) 40 - kdecore-kglobaltest (Timeout) 43 - kdecore-kconfigafterkglobaltest1 (Failed) 44 - kdecore-kconfigafterkglobaltest2 (Failed) 45 - kdecore-ktcpsockettest (Failed) 94 - kptyprocesstest (Failed) 96 - kio-krununittest (Failed) 137 - kate-completion_test (Failed) 138 - kate-searchbar_test (Failed) 140 - kate-movingrange_test (Failed) 144 - kate-indenttest (Failed) no more regressions added by this patch. Thanks, Jaime |