Re: [K3d-development] File change notification
Brought to you by:
barche
From: Timothy M. S. <ts...@k-...> - 2008-12-27 06:43:29
|
Bart Janssens wrote: > I just noticed your SVN commit. Just out of interest, what is the > benefit of having the static notifier variable declared inside the > ngui::user_interface::file_change_notifier() function, rather than > having it as a static class member? A minor stylistic nitpick - you are effectively implementing a singleton, so hiding the state of the singleton ensures that no entity accesses it before it's properly initialized. More importantly, I assume that you're going to move all threading code out of the inotify plugin so that the UI plugin decides whether to use polling or threading, as we discussed. k3d:load-order is the correct way to choose from multiple notification plugins, although in practice I doubt that there would ever be more-than-one that would successfully load. Cheers, Tim |