[Jython-bugs] [issue1648] pep328 related import problems + unittests + fix

[Anselm Kruis <report@bu...>]

New submission from Anselm Kruis <a.kruis@...>:

Hi,

Pep 328 introduces besides other features the notation of relative imports (from with dots) and "from __future__ import absolute_import". Unfortunately the jython implementation of both features is either incomplete (#1516) or broken (#1495).

Fortunately I need a fully functional pep328 implementation for my current project and could spend some time on this issue. 
The attached patch adds a new regression test "Lib/test/test_import_pep328.py". This test is pure python and also runs with c-python ("python25 test_import_pep328.py"). With c-python 2.5 the test runs OK. With the current (r7101) jython, several tests fail.

test_import_pep328.py contains two test classes: The first tests, how the parser and compiler convert import statements ("import" and "from ... import ...") into calls of the __import__ function. The second class tests, how the __import__ function handles various import situations utilizing the meta_path-hook to observe the inner workings of __import__.

I found the following defects.

- A coding bug in GrammarActions causing NPE

- Relative imports (from with at least one leading dot) call __import__ with a name containing the dots. That's probably wrong, because the information about the dots is in the level parameter of import and c-python strips the dots.

- CodeCompiler lacks support for absolute imports for "from A import *" and "import A".

- In case of an relative or absolute import (the current default), C-python calls __import__ with 4 arguments only to be compatible with previous implementations. Jython always uses the 5 argument form of __import__

- For relative imports, the computation of the full module name is broken.

Of course the test_import_pep328.py is intended to become a part of the jython test suite. I'm not sure, if I need to sign a PSF contributors agreement for it. If so, please let me know.

----------
components: Core
files: add_regrtest_for_pep328.diff
keywords: patch
messages: 6008
nosy: akruis
severity: normal
status: open
title: pep328 related import problems + unittests + fix
type: behaviour
versions: 2.5.2b1
Added file: http://bugs.jython.org/file869/add_regrtest_for_pep328.diff

_______________________________________
Jython tracker <report@...>
<http://bugs.jython.org/issue1648>;
_______________________________________

[Jython-bugs] [issue1647] zxJDBC does not handle NVARCHAR

[stephen layland <report@bu...>]

New submission from stephen layland <cru@...>:

For my purposes, all that's been necessary so far is the following one line change.

Index: src/com/ziclix/python/sql/DataHandler.java
===================================================================
--- src/com/ziclix/python/sql/DataHandler.java	(revision 7101)
+++ src/com/ziclix/python/sql/DataHandler.java	(working copy)
@@ -234,6 +234,7 @@
 
             case Types.CHAR:
             case Types.VARCHAR:
+            case Types.NVARCHAR:
                 String string = set.getString(col);
                 obj = string == null ? Py.None : Py.newUnicode(string);
                 break;

----------
components: zxjdbc
messages: 6007
nosy: cru
severity: normal
status: open
title: zxJDBC does not handle NVARCHAR
type: behaviour
versions: 2.5.2b1

_______________________________________
Jython tracker <report@...>
<http://bugs.jython.org/issue1647>;
_______________________________________