[JWebUnit-development] [ jwebunit-Bugs-3395872 ] TestingEngineResponseException created without HttpStatu

[SourceForge.net <no...@so...>]

Bugs item #3395872, was opened at 2011-08-21 22:59
Message generated for change (Comment added) made by henryju
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=497982&aid=3395872&group_id=61302

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: HtmlUnit plugin
>Group: Release 3.0.1
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Tim P (timp)
>Assigned to: Julien HENRY (henryju)
Summary: TestingEngineResponseException created without HttpStatu

Initial Comment:
HtmlUnitTestingEngineImpl.gotoPage no longer returns the failing status

   public void gotoPage(URL initialURL) throws TestingEngineResponseException {
       try {
           wc.getPage(initialURL);
           win = wc.getCurrentWindow();
           form = null;
       } catch (FailingHttpStatusCodeException ex) {
               // only throw exception if necessary
               if (!ignoreFailingStatusCodes) {
                   throw new TestingEngineResponseException(
                           "unexpected status code ["+ex.getStatusCode()+"]
at URL: ["+initialURL+"]", ex);
               }
       } catch (IOException ex) {
           throw new RuntimeException(ex);
       }
   }

should be

   public void gotoPage(URL initialURL) throws TestingEngineResponseException {
       try {
           wc.getPage(initialURL);
           win = wc.getCurrentWindow();
           form = null;
       } catch (FailingHttpStatusCodeException ex) {
               // only throw exception if necessary
               if (!ignoreFailingStatusCodes) {
                   throw new TestingEngineResponseException(ex.getStatusCode(),
                           "unexpected status code ["+ex.getStatusCode()+"]
at URL: ["+initialURL+"]",  ex);
               }
       } catch (IOException ex) {
           throw new RuntimeException(ex);
       }
   }


----------------------------------------------------------------------

>Comment By: Julien HENRY (henryju)
Date: 2011-08-22 09:33

Message:
Fixed in trunk. Was caused by applying patch from issue 1864365.

I will try to push a 3.0.1 with only minor fixes.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=497982&aid=3395872&group_id=61302