From: <ah...@us...> - 2006-05-29 16:46:44
|
Revision: 10625 Author: ahuser Date: 2006-05-29 09:46:33 -0700 (Mon, 29 May 2006) ViewCVS: http://svn.sourceforge.net/jvcl/?rev=10625&view=rev Log Message: ----------- Fixed memory leak Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-05-28 21:21:44 UTC (rev 10624) +++ trunk/jvcl/run/JvTabBar.pas 2006-05-29 16:46:33 UTC (rev 10625) @@ -640,6 +640,8 @@ finally Canvas.Pen.Assign(Pen); Canvas.Brush.Assign(Brush); + Pen.Free; + Brush.Free; end; end; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2006-08-19 15:36:54
|
Revision: 10897 Author: ahuser Date: 2006-08-19 08:36:46 -0700 (Sat, 19 Aug 2006) ViewCVS: http://svn.sourceforge.net/jvcl/?rev=10897&view=rev Log Message: ----------- published missing Visible and Enabled property Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-08-18 05:20:11 UTC (rev 10896) +++ trunk/jvcl/run/JvTabBar.pas 2006-08-19 15:36:46 UTC (rev 10897) @@ -441,6 +441,8 @@ property ShowHint default False; property Height default 23; property Hint; + property Visible; + property Enabled; property Orientation; property CloseButton; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2006-08-21 18:32:20
|
Revision: 10900 Author: ahuser Date: 2006-08-21 11:32:08 -0700 (Mon, 21 Aug 2006) ViewCVS: http://svn.sourceforge.net/jvcl/?rev=10900&view=rev Log Message: ----------- New property OnLeftTabChange Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-08-21 17:57:41 UTC (rev 10899) +++ trunk/jvcl/run/JvTabBar.pas 2006-08-21 18:32:08 UTC (rev 10900) @@ -473,6 +473,7 @@ property OnTabSelected; property OnTabMoved; property OnChange; + property OnLeftTabChange; property OnMouseDown; property OnMouseMove; @@ -1572,6 +1573,7 @@ Invalidate; if Assigned(FOnScrollButtonClick) then FOnScrollButtonClick(Self, Button); + LeftTabChanged; end; function TJvCustomTabBar.MakeVisible(Tab: TJvTabBarItem): Boolean; @@ -1596,7 +1598,7 @@ else if R.Left < 0 then begin Dec(FLeftIndex); - AtLeft := True; // prevent an endless loop + AtLeft := True; // prevent an endless loop end else Break; @@ -1610,6 +1612,7 @@ begin UpdateScrollButtons; Invalidate; + LeftTabChanged; end; end; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ob...@us...> - 2006-08-30 13:15:54
|
Revision: 10922 Author: obones Date: 2006-08-30 06:15:47 -0700 (Wed, 30 Aug 2006) ViewCVS: http://svn.sourceforge.net/jvcl/?rev=10922&view=rev Log Message: ----------- Mantis 3879: Setting FTabs to nil was a bad idea Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-08-29 16:57:31 UTC (rev 10921) +++ trunk/jvcl/run/JvTabBar.pas 2006-08-30 13:15:47 UTC (rev 10922) @@ -1,4 +1,4 @@ -{----------------------------------------------------------------------------- +{----------------------------------------------------------------------------- The contents of this file are subject to the Mozilla Public License Version 1.1 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at @@ -566,8 +566,9 @@ Painter := nil; Images := nil; FChangeLink.Free; - FreeAndNil(FTabs); - FreeAndNil(FScrollButtonBackground); + FTabs.Free; + FScrollButtonBackground.Free; + inherited Destroy; end; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ob...@us...> - 2006-08-30 20:33:31
|
Revision: 10923 http://svn.sourceforge.net/jvcl/?rev=10923&view=rev Author: obones Date: 2006-08-30 13:33:22 -0700 (Wed, 30 Aug 2006) Log Message: ----------- Deleted the BOM Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-08-30 13:15:47 UTC (rev 10922) +++ trunk/jvcl/run/JvTabBar.pas 2006-08-30 20:33:22 UTC (rev 10923) @@ -1,4 +1,4 @@ -{----------------------------------------------------------------------------- +{----------------------------------------------------------------------------- The contents of this file are subject to the Mozilla Public License Version 1.1 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2006-10-11 16:39:41
|
Revision: 10973 http://svn.sourceforge.net/jvcl/?rev=10973&view=rev Author: ahuser Date: 2006-10-11 09:39:26 -0700 (Wed, 11 Oct 2006) Log Message: ----------- Fixed access violation Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-10-11 16:38:43 UTC (rev 10972) +++ trunk/jvcl/run/JvTabBar.pas 2006-10-11 16:39:26 UTC (rev 10973) @@ -567,7 +567,9 @@ Images := nil; FChangeLink.Free; FTabs.Free; + FTabs := nil; FScrollButtonBackground.Free; + FScrollButtonBackground := nil; inherited Destroy; end; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2006-10-16 19:08:41
|
Revision: 10979 http://svn.sourceforge.net/jvcl/?rev=10979&view=rev Author: ahuser Date: 2006-10-16 12:08:19 -0700 (Mon, 16 Oct 2006) Log Message: ----------- Mantis 3956: JvTabbar repeat scrolling does not work with the left button (Mantis #3956) Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-10-16 11:21:20 UTC (rev 10978) +++ trunk/jvcl/run/JvTabBar.pas 2006-10-16 19:08:19 UTC (rev 10979) @@ -1157,7 +1157,7 @@ Result := False; if (FBtnLeftScroll.State <> sbsHidden) then Result := HandleButton(sbScrollLeft, FBtnLeftScroll.State, X, Y, FBtnLeftScroll.Rect); - if (FBtnRightScroll.State <> sbsHidden) then + if not Result and (FBtnRightScroll.State <> sbsHidden) then Result := HandleButton(sbScrollRight, FBtnRightScroll.State, X, Y, FBtnRightScroll.Rect); end; @@ -1210,7 +1210,7 @@ Result := False; if (FBtnLeftScroll.State <> sbsHidden) then Result := HandleButton(FBtnLeftScroll.ExState, FBtnLeftScroll.State, X, Y, FBtnLeftScroll.Rect); - if (FBtnRightScroll.State <> sbsHidden) then + if not Result and (FBtnRightScroll.State <> sbsHidden) then Result := HandleButton(FBtnRightScroll.ExState, FBtnRightScroll.State, X, Y, FBtnRightScroll.Rect); end; @@ -1238,7 +1238,7 @@ Result := False; if (FBtnLeftScroll.State <> sbsHidden) then Result := HandleButton(sbScrollLeft, FBtnLeftScroll.State, X, Y, FBtnLeftScroll.Rect); - if (FBtnRightScroll.State <> sbsHidden) then + if not Result and (FBtnRightScroll.State <> sbsHidden) then Result := HandleButton(sbScrollRight, FBtnRightScroll.State, X, Y, FBtnRightScroll.Rect); end; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2006-10-28 13:17:24
|
Revision: 10992 http://svn.sourceforge.net/jvcl/?rev=10992&view=rev Author: ahuser Date: 2006-10-28 06:17:14 -0700 (Sat, 28 Oct 2006) Log Message: ----------- Fixed possible access violation Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2006-10-25 23:37:25 UTC (rev 10991) +++ trunk/jvcl/run/JvTabBar.pas 2006-10-28 13:17:14 UTC (rev 10992) @@ -1455,7 +1455,7 @@ function TJvCustomTabBar.GetLeftTab: TJvTabBarItem; begin - if FLeftIndex < Tabs.Count then + if (Tabs <> nil) and (FLeftIndex < Tabs.Count) then begin Result := Tabs[FLeftIndex]; if not Result.Visible then @@ -1474,8 +1474,7 @@ if Assigned(Value) then begin // find first visible before or at Value.Index - Index := 0; - if (Tabs.Count > 0) and (Value <> Tabs[0]) then + if (Tabs <> nil) and (Tabs.Count > 0) and (Value <> Tabs[0]) then begin while Index < Tabs.Count do begin @@ -1988,7 +1987,7 @@ TabBar.FClosingTab := nil; if TabBar.FLastInsertTab = Item then TabBar.FLastInsertTab := nil; - if TabBar.LeftTab = Item then + if not (csDestroying in TabBar.ComponentState) and (TabBar.LeftTab = Item) then TabBar.LeftTab := TabBar.LeftTab.GetPreviousVisible; end; if TabBar.PageListTabLink and Assigned(TabBar.PageList) and This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2007-06-24 12:19:06
|
Revision: 11383 http://svn.sourceforge.net/jvcl/?rev=11383&view=rev Author: ahuser Date: 2007-06-24 05:19:04 -0700 (Sun, 24 Jun 2007) Log Message: ----------- Added Mantis #4152: JvTabBar - Should be possible to drop tab on empty space (Mantis #4152) Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2007-06-24 12:09:45 UTC (rev 11382) +++ trunk/jvcl/run/JvTabBar.pas 2007-06-24 12:19:04 UTC (rev 11383) @@ -892,6 +892,13 @@ if AllowTabMoving then begin InsertTab := TabAt(X, Y); + if not Assigned(InsertTab) then + if Assigned(LeftTab) and (X < LeftTab.FLeft) then + InsertTab := LeftTab + else + if Tabs.Count > 0 then + InsertTab := Tabs[Tabs.Count - 1]; + Accept := (Source = Self) and Assigned(SelectedTab) and (InsertTab <> SelectedTab) and Assigned(InsertTab); if Accept then @@ -934,10 +941,16 @@ if AllowTabMoving and (Source = Self) and Assigned(SelectedTab) then begin InsertTab := TabAt(X, Y); + if not Assigned(InsertTab) then + if Assigned(LeftTab) and (X < LeftTab.FLeft) then + InsertTab := LeftTab + else + InsertTab := Tabs[Tabs.Count - 1]; if Assigned(InsertTab) then begin SelectedTab.Index := InsertTab.Index; TabMoved(SelectedTab); + SelectedTab.MakeVisible; UpdateScrollButtons; end; end This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ah...@us...> - 2007-08-13 16:55:08
|
Revision: 11448 http://jvcl.svn.sourceforge.net/jvcl/?rev=11448&view=rev Author: ahuser Date: 2007-08-13 09:55:06 -0700 (Mon, 13 Aug 2007) Log Message: ----------- Showing a dialog in OnClosing cause an hanging drag operation Modified Paths: -------------- trunk/jvcl/run/JvTabBar.pas Modified: trunk/jvcl/run/JvTabBar.pas =================================================================== --- trunk/jvcl/run/JvTabBar.pas 2007-08-12 16:56:52 UTC (rev 11447) +++ trunk/jvcl/run/JvTabBar.pas 2007-08-13 16:55:06 UTC (rev 11448) @@ -1002,13 +1002,19 @@ SelectedTab := Tab; if Assigned(Tab) and (Tab = SelectedTab) then - if CloseButton and (not SelectBeforeClose or (SelectedTab = LastSelected)) and - PtInRect(CurrentPainter.GetCloseRect(Canvas, Tab, Tab.DisplayRect), Point(X, Y)) then - if TabClosing(Tab) then + if CloseButton and (not SelectBeforeClose or (SelectedTab = LastSelected)) then + begin + if PtInRect(CurrentPainter.GetCloseRect(Canvas, Tab, Tab.DisplayRect), Point(X, Y)) then begin - FMouseDownClosingTab := Tab; - SetClosingTab(Tab); + if TabClosing(Tab) then + begin + FMouseDownClosingTab := Tab; + SetClosingTab(Tab); + end; + inherited MouseDown(Button, Shift, X, Y); + Exit; end; + end; if (FClosingTab = nil) and AllowTabMoving and ([ssLeft, ssMiddle, ssRight] * Shift = [ssLeft]) then BeginDrag(False); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |