#56 Resources Not Cleaned up Upon Exception

[Anonymous]

Within the wjhk.jupload2.gui.JUploadPanelImpl class there are a couple places where exceptions can occur and if they do then I do not think all of the cleanup processes are successfully ran. One example of this would be when the doBrowse function is executed. If we are able to succesfully browse a folder, but if our users cause some form of exception to occur then methods like "this.fileChooser.shutdownNow();" on line 318 aren't executed properly. This ends up leaving us in an invalid state if our users come back and browse again. This can be illustrated by the fact that if an exception occurs while in the browse window (for example when you try to preview a TIF) then when you come back into the browse window later the mouse icon will show busy instead of the arrow. It still allows users to select files, but the icon is invalid. I'm worried that the mouse icon isn't the only problem though. Could we have runaway threads running when the shutdown process isn't called?

I'm willing to work on this issue, but am not quite sure what should be done when exceptions occur. I've tried to run the shutdown command when the exception occurs but that still doesn't change the mouse icon back to the pointer when the user comes back into the browse window.

Any guidance would be appreciated.

[Etienne]

Hi,

I definitly guess I'll give you SVN access! ;-)

I had to dig in my memory, and the code ...

shutdownNow stops the file icon calculating. No link with the mouse. But it should have a link with the used CPU.

I guess the mouse icon problem arrives in valueChanged.run().
The error about file ImageIcon should arrive here: PictureFileData.getImageIcon. Just run in debug mode (at least with eclipse), and the code get stopped when the exception is thrown.

If it's enough information for you, nice. Otherwise, please

Etienne