Menu

#27 GeometryPrecisionReducer.reduce() changes precision model

closed-fixed
Dr JTS
core (12)
5
2012-04-03
2012-03-26
Yuri Lupol
No

Expected: according to method's javadoc GeometryPrecisionResucer.reduce() should assigns precision model of input geometry to reduced one.
Actual: GeometryPrecisionResucer.reduce() always sets target precision model to reduced geometry.

Proposed fix: 'pm' instead of 'targetPM' should be passed to createFactory():

private GeometryEditor createEditor(GeometryFactory geomFactory, PrecisionModel pm)
{
if (geomFactory.getPrecisionModel() == pm)
return new GeometryEditor();
// otherwise create a geometry editor which changes PrecisionModel
GeometryFactory newFactory = createFactory(geomFactory, targetPM);
GeometryEditor geomEdit = new GeometryEditor(newFactory);
return geomEdit;
}

Discussion

  • Dr JTS

    Dr JTS - 2012-04-03

    Fixed

     
  • Dr JTS

    Dr JTS - 2012-04-03
    • labels: --> core
    • assigned_to: nobody --> dr_jts
    • status: open --> closed-fixed
     

Log in to post a comment.