[Jtidy-cvs] SF.net SVN: jtidy:[1206] branches/CodeUpdateAndJava5/src/main/java/org/w3c/ tidy

[<ad...@us...>]

Revision: 1206
          http://jtidy.svn.sourceforge.net/jtidy/?rev=1206&view=rev
Author:   aditsu
Date:     2010-11-17 20:51:20 +0000 (Wed, 17 Nov 2010)

Log Message:
-----------
fixed test 431964 - instead of using null for empty attribute values like Tidy does, and running into bug 3022414, modifying hasValue to return false for empty values seems to be a better solution

Modified Paths:
--------------
    branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/AttVal.java
    branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/TidyUtils.java

Modified: branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/AttVal.java
===================================================================
--- branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/AttVal.java	2010-11-17 00:44:06 UTC (rev 1205)
+++ branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/AttVal.java	2010-11-17 20:51:20 UTC (rev 1206)
@@ -443,7 +443,7 @@
     }
     
     public boolean hasValue() {
-    	return value != null;
+    	return value != null && value.length() > 0;
     }
     
     public boolean valueIs(final String val) {

Modified: branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/TidyUtils.java
===================================================================
--- branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/TidyUtils.java	2010-11-17 00:44:06 UTC (rev 1205)
+++ branches/CodeUpdateAndJava5/src/main/java/org/w3c/tidy/TidyUtils.java	2010-11-17 20:51:20 UTC (rev 1206)
@@ -658,7 +658,6 @@
     public static String getString(final byte[] bytes, final int offset, final int length) {
         try {
             return new String(bytes, offset, Math.min(length, bytes.length - offset), "UTF8");
-            // FIXME use null for empty in tidy compatibility mode, required for test 431964 
         } catch (UnsupportedEncodingException e) {
             throw new Error("UTF-8 to string conversion failed: " + e.getMessage());
         }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.