Menu
▾
▴
[Jtidy-devel] [ jtidy-Bugs-3038697 ] Remove lots of the reasons for failing junit-tests
|
From: SourceForge.net <no...@so...> - 2010-10-26 18:59:49
|
Bugs item #3038697, was opened at 2010-08-03 10:48 Message generated for change (Comment added) made by fgiust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038697&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: Remove lots of the reasons for failing junit-tests Initial Comment: Most junit tests were failing because there were jtidy-version information in the resulting messages definied. I have fixed those issues plus some general issues, so that there should be 'only' around 90 failing junit tests at the end. ---------------------------------------------------------------------- >Comment By: fabrizio giustina (fgiust) Date: 2010-10-26 20:59 Message: The fix for the removal of the initial message have been committed to both trunk and the java5 branch. I didn't committed any other change to the expected output, they probably have to be reviewed to see if the new output is really ok. After this change, the result from trunk is: Tests run: 309, Failures: 115, Errors: 7 (which is pretty close to the 100 failures/1 error status in revision 812 -the last revision in which those tests have been considered before checking in patches) ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:13 Message: I have recognized, that most of the problems occured because the testcases have jtidy version information inside, but the option set to off in the test-case settings. So I decided to remove those settings. For the other changes i was comparing the actual in- and output of the test cases and seeing wheter the results are matching the excepted values. However it is in many cases really hard to decide... Several of the occuring errors are really problems which needs to be fixed - I haven't done any changes there. After beeing back from holidays I could also provide you with peperated patches for the test cases if you like. However there are so many... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 02:36 Message: Um.. did you create this patch just by running the tests and assuming the current output is correct? If so, why do you think it is good to make that assumption? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 12:14 Message: Ok. I'll send you a patch so that maven produces 1.4 code,too (in trunk) and have a look on the new sources. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 11:43 Message: I don't use maven so I can't comment on the pom, but afaik, the DOM part of the java api was added in 1.4, so JTidy couldn't run in 1.3 (or maybe only part of it). Also, recent versions of JTidy were compiled for 1.4. Yes, that branch is usable and I think better than trunk at this point, but I'm not sure about organizing the new classes, maybe you can take a look and give some feedback. The new test suite is TidyTests. Thanks for your contributions. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 11:28 Message: Java compatibility is set to 1.3 in the pom.xml in trunk. I think, it whould be set to 1.4, as it 1.3 is outdated for a long time. Is the current CodeUpdateAndJava5 branch useable? Then I would possibly to switch to that branch and help improving jtidy (as my time allows me so). ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 11:07 Message: I kind of gave up on those test cases, and made a new test suite on the CodeUpdateAndJava5 branch, where "only" 73 tests fail now (meaning the result is not 100% byte-by-byte identical with Tidy). But I think it's good to fix these tests too, especially if we plan to maintain the trunk version (compatible with java 1.4) longer. I'll check your patch when I find some time. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038697&group_id=13153 |
