[Jtidy-devel] [ jtidy-Bugs-3038730 ] patch: fixed maven warnings in trunk; produce java 1.4 code

[SourceForge.net <no...@so...>]

Bugs item #3038730, was opened at 2010-08-03 12:17
Message generated for change (Comment added) made by weberho
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Johannes Weberhofer (weberho)
Assigned to: Adrian Sandor (aditsu)
Summary: patch: fixed maven warnings in trunk; produce java 1.4 code 

Initial Comment:
This patch fixes the maven file, as it includes version definitions for the different plugins and produces java 1.4 code instead of 1.3 code...

----------------------------------------------------------------------

>Comment By: Johannes Weberhofer (weberho)
Date: 2010-08-17 11:15

Message:
It' by convention, that test cases have usually the name of the tested
class+Test at the end.
TidyTestCase is the base for all the tests. It opens all the input stuff,
executes jtidy and compares the output with the given results and messages.
It works quite well. I have extedned it a bit to write the different output
to the disk so that I can more easily compare the expected and the real
output as well as the messages... I could post that patches, too.

----------------------------------------------------------------------

Comment By: Adrian Sandor (aditsu)
Date: 2010-08-17 10:39

Message:
Thanks for the files.
maven executes all *test.java? That sounds really stupid...
TidyTest actually IS a proper junit test, it just needs to be constructed
with parameters.
I run the tests using the TidyTests class which is a junit test suite. And
I use eclipse to run it, but it could be done from ant or something else
too.

Btw, I think the TidyTestCase class is trying to do something similar to
my TidyTest class, but it looks way too complicated, I don't remember if I
analyzed it or just gave up.

----------------------------------------------------------------------

Comment By: Johannes Weberhofer (weberho)
Date: 2010-08-17 09:26

Message:
I have attached two files; one for the trunk, one for the java5 version.
Btw. I have had a look on the new testcases which looked good. But I we'd
like to keep the existing testcases (I could try to "fix" them), You should
not name the file "TidyTest.java", because maven executes all those
*test.java" files upon packaging. As the tests are no junit-tests, the
executin fails. I have renamed the file to TidyTeser.java, that helped. How
do you currently start the new tests?

----------------------------------------------------------------------

Comment By: Adrian Sandor (aditsu)
Date: 2010-08-17 01:28

Message:
Hi, I'm having some problems with the patch, could you please attach the
complete pom.xml file?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153