Menu
▾
▴
jtidy-devel — JTidy mailing list for developers
You can subscribe to this list here.
| 2004 |
Jan
(29) |
Feb
(1) |
Mar
(6) |
Apr
(31) |
May
(2) |
Jun
(2) |
Jul
(13) |
Aug
(31) |
Sep
(41) |
Oct
(12) |
Nov
(13) |
Dec
(4) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(17) |
Feb
(3) |
Mar
(3) |
Apr
|
May
(1) |
Jun
(2) |
Jul
(1) |
Aug
(3) |
Sep
(3) |
Oct
(1) |
Nov
(2) |
Dec
(6) |
| 2006 |
Jan
(4) |
Feb
(6) |
Mar
(2) |
Apr
(1) |
May
|
Jun
|
Jul
(21) |
Aug
(7) |
Sep
(5) |
Oct
(4) |
Nov
(2) |
Dec
(2) |
| 2007 |
Jan
(1) |
Feb
|
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
(1) |
Aug
(2) |
Sep
(2) |
Oct
(2) |
Nov
|
Dec
(1) |
| 2008 |
Jan
(1) |
Feb
(1) |
Mar
(7) |
Apr
(2) |
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
(1) |
Oct
(1) |
Nov
(2) |
Dec
(8) |
| 2009 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
(2) |
Jun
(2) |
Jul
(5) |
Aug
(24) |
Sep
(16) |
Oct
(8) |
Nov
(42) |
Dec
(3) |
| 2010 |
Jan
(8) |
Feb
(8) |
Mar
(14) |
Apr
(29) |
May
(2) |
Jun
(1) |
Jul
(11) |
Aug
(47) |
Sep
(4) |
Oct
(16) |
Nov
(18) |
Dec
|
| 2011 |
Jan
(5) |
Feb
(4) |
Mar
(2) |
Apr
|
May
|
Jun
(10) |
Jul
(50) |
Aug
(4) |
Sep
(4) |
Oct
(1) |
Nov
(4) |
Dec
|
| 2012 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(2) |
Jun
(8) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2017 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2010-10-04 09:22:14
|
Bugs item #3080816, was opened at 2010-10-04 11:22 Message generated for change (Tracker Item Submitted) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080816&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Nobody/Anonymous (nobody) Summary: pom.xml - more patches Initial Comment: Some fixes regarding fixing the project information itself. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080816&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-10-04 09:02:23
|
Bugs item #3080800, was opened at 2010-10-04 11:01 Message generated for change (Settings changed) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080800&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Nobody/Anonymous (nobody) >Summary: pom.xml - patches Initial Comment: Attached you'll find two patches which fix tickets #3078662 and #3077955 I have increased the version number for the update-trunk, too. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080800&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-10-04 09:01:40
|
Bugs item #3080800, was opened at 2010-10-04 11:01 Message generated for change (Tracker Item Submitted) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080800&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Nobody/Anonymous (nobody) Summary: pom.xmlcorrections Initial Comment: Attached you'll find two patches which fix tickets #3078662 and #3077955 I have increased the version number for the update-trunk, too. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3080800&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-09-30 12:41:18
|
Bugs item #3078662, was opened at 2010-09-30 13:41 Message generated for change (Tracker Item Submitted) made by cspike You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3078662&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: cspike (cspike) Assigned to: Nobody/Anonymous (nobody) Summary: pom file in source release Initial Comment: Could you please add the pom.xml to the source release and fix the ant target accordingly. It makes distribution packaging a lot easier. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3078662&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-09-29 12:11:31
|
Bugs item #3077955, was opened at 2010-09-29 14:11 Message generated for change (Tracker Item Submitted) made by You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3077955&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tidy functionality Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Stanislav Ochotnicky () Assigned to: Nobody/Anonymous (nobody) Summary: pom.xml provide correct groupId Initial Comment: Currently groupId in pom.xml is "jtidy". However maven repositories have been using net.sf.jtidy:jtidy to identify correct artifactId. Please correct this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3077955&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-09-19 14:16:58
|
Bugs item #3071265, was opened at 2010-09-19 14:16 Message generated for change (Tracker Item Submitted) made by martinkurz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3071265&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Martin (martinkurz) Assigned to: Nobody/Anonymous (nobody) Summary: NPE on appendChild with attribute node Initial Comment: for problem description see http://sourceforge.net/projects/jtidy/forums/forum/41437/topic/3787602 analysis: on appending a new child, the new child nodes type is checked on field adaptee.type, in attribute nodes, this is null (the field is called avAadaptee instead) solution: first check, if new childnode is an attribute node before checking adaptee.type, patch for java5 branch including testcase attached ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3071265&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-09-01 11:15:21
|
Bugs item #3057375, was opened at 2010-09-01 13:15 Message generated for change (Tracker Item Submitted) made by rmacnell You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3057375&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tidy functionality Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Robert Mac Nelly (rmacnell) Assigned to: Nobody/Anonymous (nobody) Summary: NullPointerException in PPrint.printText Initial Comment: Tidy creates a TextNode without any content if there is an inline element starting with whitespace after another element (block or inline) Example: <div>foo</div><span> bar</span> Tidy creates: [Node type=StartTag,element=div,content= [Node type=TextNode,element=null,text="foo",content=null] ], [Node type=TextNode,element=null,text=null,content=null], [Node type=StartTag,element=span,content= [Node type=TextNode,element=null,text="bar",content=null] ] ] In Method PPrint.printText node.textarray is null and c = (textarray[i]) & 0xFF; raises a NullPointerException I added following workaround to PPrint.printTree: if (node.type == Node.TEXT_NODE || (node.type == Node.CDATA_TAG && lexer.configuration.escapeCdata)) { if(null==node.textarray)return; //WORKAROUND printText(fout, mode, indent, node.textarray, node.start, node.end); } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3057375&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-22 17:22:44
|
Bugs item #3050912, was opened at 2010-08-22 17:22 Message generated for change (Tracker Item Submitted) made by martinkurz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050912&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: DOM Support Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Martin (martinkurz) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for #2010634 Initial Comment: Patch for consistency on setData and setNodeValue on DOMCharacterDataImpl on branch CodeUpdateAndJava5 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050912&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-22 17:20:58
|
Bugs item #2010634, was opened at 2008-07-04 13:10 Message generated for change (Comment added) made by martinkurz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=2010634&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: DOM Support Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jeff MAURY (jeffmaury) Assigned to: Nobody/Anonymous (nobody) Summary: Incorrect behaviour on Text nodes Initial Comment: On Text nodes, it is impossible to modify the content of the node. The setData method raises an exception telling the node is not modifiable. However, if you use the setNodeValue of the Node interface, no exception is raised and the node is modified. This behaviour is inconsistent and may lead JTidy adopters to write code that may be not upward compatible ---------------------------------------------------------------------- Comment By: Martin (martinkurz) Date: 2010-08-22 17:20 Message: That's really inconsistent, created a patch for DOMCharacterDataImpl in branch CodeUpdateAndJava5. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=2010634&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-22 15:01:34
|
Bugs item #3050836, was opened at 2010-08-22 15:01 Message generated for change (Tracker Item Submitted) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050836&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: DOM Support Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Support for DocumentFragment Initial Comment: added support for DocumentFragment in branch CodeUpdateAndJava5, patch attached ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050836&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-22 15:00:22
|
Bugs item #3050833, was opened at 2010-08-22 15:00 Message generated for change (Tracker Item Submitted) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050833&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tidy functionality Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: NPEs on ConfigurationTest Initial Comment: When executing ConfigurationTest, there are some NPEs in class Configuration, Ptach for null checking attached. (branch CodeUpdateAndJava5) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3050833&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-20 15:50:50
|
Feature Requests item #3049436, was opened at 2010-08-20 11:50 Message generated for change (Tracker Item Submitted) made by tobinibot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=363153&aid=3049436&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Tobin Juday (tobinibot) Assigned to: Nobody/Anonymous (nobody) Summary: Curly quotes Initial Comment: I propose that the substitution of curly quotes and dashes into their regular ASCII versions be driven only by the asciiChars property. Currently, here is the if statement for running the substitution: if (this.configuration.makeClean && this.configuration.asciiChars || this.configuration.makeBare) I'm in the situation where I want to clean Word html (and so makeBare is true), but I want to leave in the curly quotes (because my html parser can handle them). Currently, there's no way I can do that. I would like the line to read: if (this.configuration.makeClean && this.configuration.asciiChars || this.configuration.makeBare && this.configuration.asciiChars) This would allow me to use makeBare (and makeClean), and still keep my curly quotes by setting asciiChars to false. I understand that this would break users who are using makeBare and counting on the curly quote substitution. To keep that old behavior, we could also add a new field, something like keepSpecialChars. In that case, the line would now look something like: if (this.configuration.makeClean && this.configuration.asciiChars || this.configuration.makeBare && !this.configuration.keepSpecialChars) However, it seems sort of silly to add a new property when we've already got the asciiChars property for exactly this reason. Basically, I just need to be able to clean Word html, but keep curly quotes. I don't really care how it's implemented. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=363153&aid=3049436&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-19 23:27:28
|
Bugs item #3038802, was opened at 2010-08-03 21:38 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038802&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch jtidy2: remove dead code Initial Comment: Eclipse has detected some unused code in the CodeUpdatedAndJava5 branch. I have reviewed and removed that code. ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-20 07:27 Message: Committed now ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 09:15 Message: I don't see why "node" couldn't become null inside the while loop (line 2157: node = next;) and throw NPE. The C code in Tidy actually checks for null in the while loop condition. So I think we have a bug here, although I don't have a test case for it. Unless you have a different opinion, I will fix this by checking for null in the while condition, and keeping the existing "break if null" after the loop. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-12 18:04 Message: Adrian, yes, the patches could also be applied to trunk. I have checked the Clean.java code, and am yuite sure, that after exiting the "while (node.is(TagId.P) && noMargins(node))" section, there will alwys be remaining nodes: The paragraphs are striped off, and newLineNodes are added instead. As the while-section is only reached when nodes exist, there must be nodes upon leaving, too. Hope I'm right... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-12 07:37 Message: Doesn't this also apply to trunk? Anyway, it doesn't affect much.. unless it uncovers bugs; I think the dead code in Clean.java needs some review. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038802&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-18 01:24:49
|
Bugs item #3038730, was opened at 2010-08-03 18:17 Message generated for change (Settings changed) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch: fixed maven warnings in trunk; produce java 1.4 code Initial Comment: This patch fixes the maven file, as it includes version definitions for the different plugins and produces java 1.4 code instead of 1.3 code... ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-18 09:24 Message: The convention is alright, but I think it shouldn't just blindly try to run all classes that follow a certain naming pattern. You're right, TidyTestCase is the base class, I just noticed some parts of it such as some code to invoke tidy(.exe) and compare outputs. I wrote my own TidyTest to keep it simple, and I renamed it now to TidyTester to avoid any problems. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 17:15 Message: It' by convention, that test cases have usually the name of the tested class+Test at the end. TidyTestCase is the base for all the tests. It opens all the input stuff, executes jtidy and compares the output with the given results and messages. It works quite well. I have extedned it a bit to write the different output to the disk so that I can more easily compare the expected and the real output as well as the messages... I could post that patches, too. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 16:39 Message: Thanks for the files. maven executes all *test.java? That sounds really stupid... TidyTest actually IS a proper junit test, it just needs to be constructed with parameters. I run the tests using the TidyTests class which is a junit test suite. And I use eclipse to run it, but it could be done from ant or something else too. Btw, I think the TidyTestCase class is trying to do something similar to my TidyTest class, but it looks way too complicated, I don't remember if I analyzed it or just gave up. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 15:26 Message: I have attached two files; one for the trunk, one for the java5 version. Btw. I have had a look on the new testcases which looked good. But I we'd like to keep the existing testcases (I could try to "fix" them), You should not name the file "TidyTest.java", because maven executes all those *test.java" files upon packaging. As the tests are no junit-tests, the executin fails. I have renamed the file to TidyTeser.java, that helped. How do you currently start the new tests? ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 07:28 Message: Hi, I'm having some problems with the patch, could you please attach the complete pom.xml file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-18 01:06:50
|
Bugs item #2990554, was opened at 2010-04-22 03:09 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=2990554&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tidy functionality Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Adrian Sandor (aditsu) Summary: Tidy can wrap line in the middle of utf8 byte sequence. Initial Comment: I have used jtidy to clean up xml files. In some cases it produce files with incorrect symbols(0x0 symbol in utf8 xml files). I spent some time to debug: Tidy use line wrapping by default and have a bug with line wrapping. Tidy can wrap line in the middle of utf8 byte sequence. ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-18 09:06 Message: Hi, can you please check if this bug is now fixed in SVN? (due to fixing bug 3038314) ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-04-24 15:21 Message: Hi, first of all, what JTidy version are you using? Your patch doesn't compile with the current code. By the way, you can attach files to bug reports. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-04-22 20:05 Message: I have fixed it. Sorry, my first assumption was wrong. Problem in PPrint.java lines 706, 721. Code is: wraphere = linelen + 2; // 2, because AddChar is not till later but is should be: wraphere = linelen + 1; // 1, because we have arrays uses 0 as first char index and position of last symbol is len - 1 and because AddChar is not till later I have uploaded file with my changes. http://tuzikbottle.com/images/exchange/PPrint.java If you have any question mail me to vyacheslav.gudkov at gmail.com ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-04-22 16:09 Message: There is a test file: <root> <a>1,1′-azobis</a> </root> My test settings: Tidy tidy = new Tidy(); tidy.setXmlTags(true); tidy.setXmlOut(true); tidy.setFixBackslash(true); // replace \ with / in urls tidy.setFixComments(true); // detect mal-formed comments tidy.setHideComments(true); // hide all comments tidy.setHideEndTags(true); // prefer self-closing tag where possible tidy.setLowerLiterals(true); // output lower-case attrib names tidy.setMakeBare(true); // clean Microsoft cruft tidy.setNumEntities(true); // prefer number entities to named ones tidy.setTidyMark(false); // don't add meta tag giving tidy credit tidy.setOutputEncoding("UTF-8");// force tidy to report encoding as utf-8 instead of other tidy.setQuoteNbsp(true); // if char 160 is found, output as tidy.setMakeClean(true); // remove presentational clutter tidy.setDocType("omit"); tidy.setWraplen(9); ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-04-22 15:04 Message: I try to fix it today and upload patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=2990554&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-18 00:59:59
|
Bugs item #3038314, was opened at 2010-08-02 22:50 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open >Resolution: Fixed Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: encoding of last "-" character is not working correctly Initial Comment: in the test's case the last '-' character at the end of the paragraph is not encoded correctly. ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-18 08:59 Message: Well, I committed the fix, but the test case you added doesn't work on trunk - it tries to parse "SUMMARY" (message level) as a number. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 17:49 Message: Haha, thanks, I'll go ahead and commit then (a bit later). ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 16:35 Message: I couldn't wait. The problem has gone - thank you! I have re-uploaded all files to create a test case (for the old system and this failure). ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 15:14 Message: I'll check in two weeks... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 08:25 Message: Hi, could you try the attached patch please? It seems to fix the problem but I wonder if it breaks anything. Btw, it doesn't seem to break any more tests on the java5 branch. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 01:22 Message: I'm using trunk. I have seen the problem for at least two years but never filed a bug. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 01:05 Message: What version of jtidy did you use and what program/command did you run? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 00:46 Message: I have attached jtidies' output. Have a look at the "incluindo – mas" section. I have tried to shorten the problematic sequence as short as I can. The strange thing is that - when you remove some things from the beginning, everything works nicely. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 23:10 Message: I opened both the input and output files in a browser and they look identical. Even the html source looks identical except for different line wrapping. What exactly is the problem? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 22:58 Message: the '-' is a unicode character, not a regular - sign. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 09:49:08
|
Bugs item #3038314, was opened at 2010-08-02 22:50 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: encoding of last "-" character is not working correctly Initial Comment: in the test's case the last '-' character at the end of the paragraph is not encoded correctly. ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 17:49 Message: Haha, thanks, I'll go ahead and commit then (a bit later). ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 16:35 Message: I couldn't wait. The problem has gone - thank you! I have re-uploaded all files to create a test case (for the old system and this failure). ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 15:14 Message: I'll check in two weeks... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 08:25 Message: Hi, could you try the attached patch please? It seems to fix the problem but I wonder if it breaks anything. Btw, it doesn't seem to break any more tests on the java5 branch. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 01:22 Message: I'm using trunk. I have seen the problem for at least two years but never filed a bug. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 01:05 Message: What version of jtidy did you use and what program/command did you run? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 00:46 Message: I have attached jtidies' output. Have a look at the "incluindo – mas" section. I have tried to shorten the problematic sequence as short as I can. The strange thing is that - when you remove some things from the beginning, everything works nicely. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 23:10 Message: I opened both the input and output files in a browser and they look identical. Even the html source looks identical except for different line wrapping. What exactly is the problem? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 22:58 Message: the '-' is a unicode character, not a regular - sign. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 09:15:09
|
Bugs item #3038730, was opened at 2010-08-03 12:17 Message generated for change (Comment added) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch: fixed maven warnings in trunk; produce java 1.4 code Initial Comment: This patch fixes the maven file, as it includes version definitions for the different plugins and produces java 1.4 code instead of 1.3 code... ---------------------------------------------------------------------- >Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 11:15 Message: It' by convention, that test cases have usually the name of the tested class+Test at the end. TidyTestCase is the base for all the tests. It opens all the input stuff, executes jtidy and compares the output with the given results and messages. It works quite well. I have extedned it a bit to write the different output to the disk so that I can more easily compare the expected and the real output as well as the messages... I could post that patches, too. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 10:39 Message: Thanks for the files. maven executes all *test.java? That sounds really stupid... TidyTest actually IS a proper junit test, it just needs to be constructed with parameters. I run the tests using the TidyTests class which is a junit test suite. And I use eclipse to run it, but it could be done from ant or something else too. Btw, I think the TidyTestCase class is trying to do something similar to my TidyTest class, but it looks way too complicated, I don't remember if I analyzed it or just gave up. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:26 Message: I have attached two files; one for the trunk, one for the java5 version. Btw. I have had a look on the new testcases which looked good. But I we'd like to keep the existing testcases (I could try to "fix" them), You should not name the file "TidyTest.java", because maven executes all those *test.java" files upon packaging. As the tests are no junit-tests, the executin fails. I have renamed the file to TidyTeser.java, that helped. How do you currently start the new tests? ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 01:28 Message: Hi, I'm having some problems with the patch, could you please attach the complete pom.xml file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 08:39:53
|
Bugs item #3038730, was opened at 2010-08-03 18:17 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch: fixed maven warnings in trunk; produce java 1.4 code Initial Comment: This patch fixes the maven file, as it includes version definitions for the different plugins and produces java 1.4 code instead of 1.3 code... ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 16:39 Message: Thanks for the files. maven executes all *test.java? That sounds really stupid... TidyTest actually IS a proper junit test, it just needs to be constructed with parameters. I run the tests using the TidyTests class which is a junit test suite. And I use eclipse to run it, but it could be done from ant or something else too. Btw, I think the TidyTestCase class is trying to do something similar to my TidyTest class, but it looks way too complicated, I don't remember if I analyzed it or just gave up. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 15:26 Message: I have attached two files; one for the trunk, one for the java5 version. Btw. I have had a look on the new testcases which looked good. But I we'd like to keep the existing testcases (I could try to "fix" them), You should not name the file "TidyTest.java", because maven executes all those *test.java" files upon packaging. As the tests are no junit-tests, the executin fails. I have renamed the file to TidyTeser.java, that helped. How do you currently start the new tests? ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 07:28 Message: Hi, I'm having some problems with the patch, could you please attach the complete pom.xml file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 08:35:43
|
Bugs item #3038314, was opened at 2010-08-02 16:50 Message generated for change (Comment added) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: encoding of last "-" character is not working correctly Initial Comment: in the test's case the last '-' character at the end of the paragraph is not encoded correctly. ---------------------------------------------------------------------- >Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 10:35 Message: I couldn't wait. The problem has gone - thank you! I have re-uploaded all files to create a test case (for the old system and this failure). ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:14 Message: I'll check in two weeks... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 02:25 Message: Hi, could you try the attached patch please? It seems to fix the problem but I wonder if it breaks anything. Btw, it doesn't seem to break any more tests on the java5 branch. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 19:22 Message: I'm using trunk. I have seen the problem for at least two years but never filed a bug. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 19:05 Message: What version of jtidy did you use and what program/command did you run? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 18:46 Message: I have attached jtidies' output. Have a look at the "incluindo – mas" section. I have tried to shorten the problematic sequence as short as I can. The strange thing is that - when you remove some things from the beginning, everything works nicely. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 17:10 Message: I opened both the input and output files in a browser and they look identical. Even the html source looks identical except for different line wrapping. What exactly is the problem? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 16:58 Message: the '-' is a unicode character, not a regular - sign. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 07:26:55
|
Bugs item #3038730, was opened at 2010-08-03 12:17 Message generated for change (Comment added) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch: fixed maven warnings in trunk; produce java 1.4 code Initial Comment: This patch fixes the maven file, as it includes version definitions for the different plugins and produces java 1.4 code instead of 1.3 code... ---------------------------------------------------------------------- >Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:26 Message: I have attached two files; one for the trunk, one for the java5 version. Btw. I have had a look on the new testcases which looked good. But I we'd like to keep the existing testcases (I could try to "fix" them), You should not name the file "TidyTest.java", because maven executes all those *test.java" files upon packaging. As the tests are no junit-tests, the executin fails. I have renamed the file to TidyTeser.java, that helped. How do you currently start the new tests? ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 01:28 Message: Hi, I'm having some problems with the patch, could you please attach the complete pom.xml file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038730&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 07:14:28
|
Bugs item #3038314, was opened at 2010-08-02 16:50 Message generated for change (Comment added) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: encoding of last "-" character is not working correctly Initial Comment: in the test's case the last '-' character at the end of the paragraph is not encoded correctly. ---------------------------------------------------------------------- >Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:14 Message: I'll check in two weeks... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 02:25 Message: Hi, could you try the attached patch please? It seems to fix the problem but I wonder if it breaks anything. Btw, it doesn't seem to break any more tests on the java5 branch. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 19:22 Message: I'm using trunk. I have seen the problem for at least two years but never filed a bug. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 19:05 Message: What version of jtidy did you use and what program/command did you run? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 18:46 Message: I have attached jtidies' output. Have a look at the "incluindo – mas" section. I have tried to shorten the problematic sequence as short as I can. The strange thing is that - when you remove some things from the beginning, everything works nicely. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-02 17:10 Message: I opened both the input and output files in a browser and they look identical. Even the html source looks identical except for different line wrapping. What exactly is the problem? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-02 16:58 Message: the '-' is a unicode character, not a regular - sign. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038314&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 07:13:05
|
Bugs item #3038697, was opened at 2010-08-03 10:48 Message generated for change (Comment added) made by weberho You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038697&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: Remove lots of the reasons for failing junit-tests Initial Comment: Most junit tests were failing because there were jtidy-version information in the resulting messages definied. I have fixed those issues plus some general issues, so that there should be 'only' around 90 failing junit tests at the end. ---------------------------------------------------------------------- >Comment By: Johannes Weberhofer (weberho) Date: 2010-08-17 09:13 Message: I have recognized, that most of the problems occured because the testcases have jtidy version information inside, but the option set to off in the test-case settings. So I decided to remove those settings. For the other changes i was comparing the actual in- and output of the test cases and seeing wheter the results are matching the excepted values. However it is in many cases really hard to decide... Several of the occuring errors are really problems which needs to be fixed - I haven't done any changes there. After beeing back from holidays I could also provide you with peperated patches for the test cases if you like. However there are so many... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 02:36 Message: Um.. did you create this patch just by running the tests and assuming the current output is correct? If so, why do you think it is good to make that assumption? ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 12:14 Message: Ok. I'll send you a patch so that maven produces 1.4 code,too (in trunk) and have a look on the new sources. ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 11:43 Message: I don't use maven so I can't comment on the pom, but afaik, the DOM part of the java api was added in 1.4, so JTidy couldn't run in 1.3 (or maybe only part of it). Also, recent versions of JTidy were compiled for 1.4. Yes, that branch is usable and I think better than trunk at this point, but I'm not sure about organizing the new classes, maybe you can take a look and give some feedback. The new test suite is TidyTests. Thanks for your contributions. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-03 11:28 Message: Java compatibility is set to 1.3 in the pom.xml in trunk. I think, it whould be set to 1.4, as it 1.3 is outdated for a long time. Is the current CodeUpdateAndJava5 branch useable? Then I would possibly to switch to that branch and help improving jtidy (as my time allows me so). ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-03 11:07 Message: I kind of gave up on those test cases, and made a new test suite on the CodeUpdateAndJava5 branch, where "only" 73 tests fail now (meaning the result is not 100% byte-by-byte identical with Tidy). But I think it's good to fix these tests too, especially if we plan to maintain the trunk version (compatible with java 1.4) longer. I'll check your patch when I find some time. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038697&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 02:36:31
|
Bugs item #3041886, was opened at 2010-08-09 20:10 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3041886&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: DOM Support Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Vladislav Isenbaev (udh-winger) >Assigned to: Adrian Sandor (aditsu) Summary: replaceChild shows strange behavior Initial Comment: replaceChild of JTidy DOM behaves strangely. It is not equivalent to : insertBefore(newChild,oldChild); return removeChild(oldChild); ------------------- Tidy tidy = new Tidy(); tidy.setXmlOut(true); Document doc = Tidy.createEmptyDocument(); Element html = doc.getDocumentElement(); Element a = doc.createElement("a"); Element b = doc.createElement("b"); a.appendChild(b); html.appendChild(a); tidy.pprint(doc, System.out); System.out.println("---------"); Element c = doc.createElement("c"); Element d = doc.createElement("d"); c.appendChild(d); html.replaceChild(c, a); tidy.pprint(doc, System.out); This code produces this output: <html> <a><b /> </a> </html> --------- <html> <c><b /> </c> </html> However, it should be: <html> <a><b /> </a> </html> --------- <html> <c><d /> </c> </html> ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 10:36 Message: Fixed in SVN, good catch! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3041886&group_id=13153 |
|
From: SourceForge.net <no...@so...> - 2010-08-17 01:15:42
|
Bugs item #3038802, was opened at 2010-08-03 21:38 Message generated for change (Comment added) made by aditsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038802&group_id=13153 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Johannes Weberhofer (weberho) Assigned to: Adrian Sandor (aditsu) Summary: patch jtidy2: remove dead code Initial Comment: Eclipse has detected some unused code in the CodeUpdatedAndJava5 branch. I have reviewed and removed that code. ---------------------------------------------------------------------- >Comment By: Adrian Sandor (aditsu) Date: 2010-08-17 09:15 Message: I don't see why "node" couldn't become null inside the while loop (line 2157: node = next;) and throw NPE. The C code in Tidy actually checks for null in the while loop condition. So I think we have a bug here, although I don't have a test case for it. Unless you have a different opinion, I will fix this by checking for null in the while condition, and keeping the existing "break if null" after the loop. ---------------------------------------------------------------------- Comment By: Johannes Weberhofer (weberho) Date: 2010-08-12 18:04 Message: Adrian, yes, the patches could also be applied to trunk. I have checked the Clean.java code, and am yuite sure, that after exiting the "while (node.is(TagId.P) && noMargins(node))" section, there will alwys be remaining nodes: The paragraphs are striped off, and newLineNodes are added instead. As the while-section is only reached when nodes exist, there must be nodes upon leaving, too. Hope I'm right... ---------------------------------------------------------------------- Comment By: Adrian Sandor (aditsu) Date: 2010-08-12 07:37 Message: Doesn't this also apply to trunk? Anyway, it doesn't affect much.. unless it uncovers bugs; I think the dead code in Clean.java needs some review. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=113153&aid=3038802&group_id=13153 |
31 messages has been excluded from this view by a project administrator.
