From: <chr...@ch...>
<chr...@ch...> - 2013-10-17 13:58:37
|
Hi Pascal, Packe [pa...@ya...] wrote: > > Hi, > > Yes, I have had a look at the refactor branch. My concern about that branch > was that it didn't seem active and that in some mailing list conversation > there was very high aims for what was going to be developed in that branch. > I got to a point with my refactoring where I would have liked some feedback and an indication whether the work was likely to be merged back into trunk. The lack of feedback and list activity in general lead me to the conclusion that JSynthLib is an orphaned project and that I should focus my efforts elsewhere. At the point I left it, the code in my branch compiles and loads the files created in the currently released version. I was somewhat dependent on people testing, since I didn't have any supported synths to test an existing driver. > > Therefore I felt that it would take quite a long time to merge those changes > (which seems very good btw) to trunk. > Had there been any activity in the trunk, then I would have merged or ported those changes. From what I can see, there still hasn't been any activity on the trunk since I started my branch. > > Regarding Ant vs Maven vs whatever I don't really have a firm opinion. > It's not something I have particularly strong feelings about - I'd be much more concerned in a project like JSynthLib if it mandated the use of a particular IDE. I vaguely recall someone almost doing this by trying to use the GUI builder in NetBeans many years ago. That was when the project seemed more active and I first considered trying to contribute to it - the attempt to enforce NetBean's GUI builder is what put me off. > > The benefit of Maven is that it has a resource folder right inside src which > is handy to save resources such as images in. As you mention it is also neat > to handle dependencies. > Maven seems to have adopted existing best practices in this regard. > > What would you say is left before we can merge the refactor branch to trunk? > I suspect that my branch is at least as stable as trunk, but with the beginnings of a major API cleanup. It looks like there was a clear design and decent encapsulation at some point, but that they have been broken over the years. Cleaning this up further will be a lot of work, and I wonder if it may not be better to start from scratch with the core, and just using the existing drivers as a form of documentation for new ones. > BR > /Pascal > Regards, Chris |