Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

On 04/09/2011 19:26, Martin Tarenskeen wrote:
>
>
> On Sun, 4 Sep 2011, frankster wrote:
>
>> sorry for the double post before.
>> I have put a fix to SVN. If you still have this problem, could you send
>> me a sysx file containing a patch that triggers it?
>
> Thanks. Problem has gone.
>
>>>> I have also been doing a few improvements on the envelope graphics for
>>>> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were
>>>> missing a
>>>> Sustain segment, which I have fixed now). I will send some
>>>> patches/proposals later, after the above bug has been fixed and
>>>> after I
>>>> have done some more testing with my locally modified copy.
>
> I have attached patches for the Yamaha DX7, DX100, and TX81z Single
> Voice editor. They change the Envelope Generator (level and pitch)
> graphics.
> 1. A sustain segment is now correctly Bdisplayed.
> 2. DX7 EG, PEG and DX21 PEG: The start level is the same as the end
> level (DX7 Level/Pitch 4, DX21 PEG Level 3). (read the DX7 manual) 3.
> The DX21/TX81Z envelope is a hard one. I have choosen to draw a
> horizontal line after the D1L point. This is only true if D2R=0. But
> it's as good as I could get it.
>
> I hope someone who knows how SVN works can merge my ideas into the
> trunk. (I guess I should learn how to use it before asking to get
> write access myself)
>

I have submitted your patches into SVN - although I have kept the DX7
algorithm images in their own directory (as its marginally neater than
mixed in with the Java files I think) but I have moved the images
directory into the DX7/common directory which solves the crash similarly
to your patch.

frankie