Re: [Jsynthlib-devel] patch testing

[Vladimir A. <vl...@gm...>]

Frankie:

I was planning to apply my patch for sy77 on a separate branch once I 
get svn access from Joachim. And from there I was thinking to 
investigate how to make a pre-built binary available for download at SF 
for anyone with actual hardware willing to test.

But in general synth drivers are very much self contained and should not 
touch anything outside their directory. If a new one does not break the 
build process, and does not crash the program at startup, then I would 
think they are quite safe to add and leave further testing to interested 
parties.

Of course there is always chance that new ones will interfere with 
existing working ones, breaking both in some hardware configurations. 
But that would probably be much harder to catch by reading than by testing.

So I would think quick look through the code should suffice.

I also will try to find time to look through these patches over weekend 
and will report anything I would find worth reporting. I really feel bad 
that you suddenly do so much real work, and I do just talking.

Thanks for you effort.

Vladimir

On 09/02/2011 05:18 AM, frankster wrote:
> So last night I've put in 2 patches that I made, and 2 patches that
> other people made. They were all quite small patches and it was possible
> for me to test them all. There are (at least) 3 more substantial patches
> available that its not really possible for me to test as they are
> drivers for hardware that I don't own. They are:
> 1) Vladimir's support for Yamaha SY77
> 2) Chris Arndt's partial support for Yamaha SY85 (that has sat in the
> patch queue for 2 years!)
> 3) Fred Jan Kraan's updated MT-32 driver and rudimentary driver for
> Lexicon LXP5 that he mentioned yesterday.
>
> I'm inclined to give them a read through over the weekend to check there
> are no horror stories lurking inside and then commit them.
>
> Any objections?
>
> Frankie
>
> ------------------------------------------------------------------------------
> Special Offer -- Download ArcSight Logger for FREE!
> Finally, a world-class log management solution at an even better
> price-free! And you'll get a free "Love Thy Logs" t-shirt when you
> download Logger. Secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsisghtdev2dev
> _______________________________________________
> Jsynthlib-devel mailing list
> Jsy...@li...
> https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel

-- 
Regards,
Vladimir