From: Joe E. <jo...@em...> - 2006-02-06 21:16:39
|
Rib Rdb wrote: > On 2/6/06, Joe Emenaker <jo...@em...> wrote: > > It looks like you are correct that the dialog is always displayed, and > I agree that it should only be displayed if the patch was modified. > Okay, then.... there are two ways to handle this: 1 - We can have the PatchEditorFrame superclass make a "before editing" copy of the patch (which it probably does anyway, since you can revert to it, right?) and then it can do a byte-by-byte comparison of the "after editing" data to decide whether anything was changed. 2 - We can have the PatchEditorFrame implement some kind of "boolean wasAltered()" method which would always default to "true", but each synthdriver could override. Or, maybe we could have both. Maybe the default behavior would be a byte-by-byte comparison, but individual editors could override it in cases where the patch data was just too big. - Joe |