Re: [Jsynthlib-devel] Change to Utility.hexDump?

[Hiroo H. <hir...@co...>]

Joe> I'm adding a couple of methods to Utility to allow for the 
Joe> address/offset to be printed on the left side of the line, and for the 
Joe> equivalent characters to be printed on the right side (more like a 
Joe> conventional hex editor). This shouldn't affect any existing code.

That's good.

Joe> Also, hexDumpOneLine contained, essentially, two duplicates of code in 
Joe> hexDump, so I replaced it with two calls to hexDump. Again, this 
Joe> shouldn't affect anything, since the behavior seems to be unchanged.

I'm a man who doesn't like duplicates of code, too.  There might be a
reason I coun't not use two calls to hexDump.  I can not recall what I
did on the code at a glance.  But the following problem may be a reason,
but I'm not sure.

Joe> However, I noticed that hexDump, when creating multi-line dumps, 
Joe> prepends two spaces to lines after the first one. For example:
Joe>   0A 1E 7E ...
Joe>     ED A3 4F...
Joe>     BC F1 28...
Joe> 
Joe> Can I remove that indenting... or does someone need it for something?

Please fix the method as you need.

Thanks.
-- 
Hiroo Hayashi