Re: check sum (Re: [Jsynthlib-devel] Okay... so why can't I edit a patch with this?)

[Joe E. <jo...@em...>]

Bill Zwicky wrote:

> And the only *good* solution to that is for each driver to have its 
> own private copy of checksum().  We really *don't* want changes in the 
> common code to break drivers; each driver should have its own code.

I think that we'd have more bug-free checksum methods if they were 
centralized in core.*. If there's a bug in one of the checksum methods 
that was being used by multiple synthdrivers, it would get noticed and 
fixed sooner.

The problem with changes in core breaking synthdrivers isn't a big 
problem because we have CVS. If someone breaks one of the checksum 
methods, we can easily fix it back.

Hiroo Hayashi wrote:

>And my manual for Roland synth explain check sum as follows;
>
>        aa + bb + cc + ... + hh = sum
>        sum / 128 = quotient ... remainder
>        128 - remainder = check sum
>
>It might be even more difficult to understand the method above
>implements this calculation method.
>
I consider it to be understood that there would need to be *plentiful* 
comments in a checksum class, perhaps going as far as to quote the 
checksum method from various manuals, like Hiroo has. In other words, we 
could write "If your sysex specification describes the checksum method 
as: 'aa + bb +...     128 - remainder = check sum', then use the 
following method" directly in the javadoc comment for the method.

- Joe