From: Joachim B. <jba...@pi...> - 2005-03-08 11:05:41
|
> So... what happens if the world, someday, comes up with MIDI2=20 > with some=20 > new sysex begin/end bytes instead of F0/F7? We go back and=20 > rewrite all=20 > of the drivers? Sorry, but that's absolute nonsense! The MIDI specs are programmed into the ROM of most of the synths so they cannot be changed. But independet of that I suggest to have constants for the start and end byte. Like: public static final byte SYSEX_START_BYTE =3D (byte) 0xF0; public static final byte SYSEX_END_BYTE =3D (byte) 0xF7; I have included them in my synth driver constants classes which means reduncancy. Does something speak against including them in the core/Constants class? This would also mean that we could remove the following code from the core/SysexMatcher class: public final byte F7 =3D (byte)0xF7; public final byte F0 =3D (byte)0xF0; I think the naming is confusing as the name contains already the value. Regards, Joachim Backhaus |