Re: JSLFrame related fixes (Re: SDI mode (Re: [Jsynthlib-devel] change proposal))

[Hiroo H. <hir...@co...>]

Hi,

Rib> You're probably right about the version string.  I also agree that
Rib> checking for the ScreenMenuBar probably shouldn't be in isMac().  The
Rib> problem is that without it, JSynthLib starts up with an empty menu,
Rib> and a single frame (with no title bar) containing a menu.  Someone who
Rib> see's that is going to think that JSynthLib is broken.  By making
Rib> isMac return false in this case, the behavior is acceptable.  Another
Rib> solution, if we had a library open automatically, would be to hide the
Rib> "invisible" frame and the toolbar on a Mac without the screen menu
Rib> bar, but still make JSynthLib quit when you close the last frame.  But
Rib> this seems too complicated.

Why don't we enable 'invisible window mode' only when MacOS and
ScreenMenuBar mode?

    if (isMac && System.getProperty("apple.laf.useScreenMenuBar").equals("true"))
        ((JSLFakeDesktop) proxy).createInvisibleWindow(mb);
    else
        ((JSLFakeDesktop) proxy).createToolBarWindow(title + " Tool Bar", mb, tb);

I've checked in this fix.

Rib> > And if we define default file, we can use "Patch Library Path" which
Rib> > user specifies.  But adding a user preference "default library" may be
Rib> > better idea.
Rib> 
Rib> I didn't know you could do that.  However I assume that most Mac users

I added the feature Oct 31, 2004.

Rib> will use the Application Bundle, which doesn't have a way to specify
Rib> command line arguments.  So I think it would still be a good idea to
Rib> have an option to open a library on startup.
Rib> 
Rib> This would mean another place in AppConfig where we test for
Rib> MacUtils.isMac().  Maybe we need to come up with a better way have
Rib> default options be OS dependent.

I agree with you it's good idea to add preference option to specify the
default library file for any OSs.  I can do that easily.

Thanks.
-- 
Hiroo Hayashi