Re: [Jsynthlib-devel] Change in DeviceAddDialog

[Hiroo H. <hir...@co...>]

Hi Joe,

Joe> ---------------------------------
Joe> Explaination of the layout
Joe> ---------------------------------
Joe> The tree supports grouping by manufacturer, type (ie, synth, controller, 
Joe> drum machine, etc.), manufacturer-then-type, type-then-manufacturer, or 
Joe> no grouping at all (in which case it looks just like the old JList, 
Joe> pretty much).
Joe> 
Joe> It is *currently* configured to group by Type, then by Manufacturer. The 
Joe> problem is, devices don't have types yet. In the meantime, so that we 
Joe> have something to test, the type is the first letter of the manufacturer 
Joe> name. So, a "Kawai K4" will have type "K". This is why the tree 
Joe> initially starts out with just a bunch of folders with single-letter 
Joe> names. So, the Kawai K4 is in "/K/Kawai/Kawai K4".
Joe> 
Joe> If you want to experiment with different groupings, look in 
Joe> DeviceSelectionTree and change the groupStyle field to GROUP_NONE, 
Joe> GROUP_MANUF, GROUP_TYPE, GROUP_MANUF_TYPE, or GROUP_TYPE_MANUF (which is 
Joe> what it is now). Should we just hard-code this a certain way, or let the 
Joe> user change it with a setting?

It think only having GROUP_MANUF is enough.  This dialog is used for a
user to select one of synths he owns. He knows the manufacture of his
synths.  I don't think it is worth to add complexity of having a setting
combobox (or whatever). Someday when we have a hundreds of synths
support for a manufacture we might want to have GROUP_MANUF_TYPE (it
might be only if the manufacture names product names inconsistently).
And as you wrote grouping synths into types is not easy.  There are lots
of kinds of MIDI devices.  Grouping policy may be different between
users.

And if synths are grouped by manufacture names, it is superfluous to have
a manufacture name on each node.

And minor think; use ErrorMsg.reportStatus() instead of
System.out.println().


Anyway great job!  Thank you.
-- 
Hiroo Hayashi