From: Joe E. <jo...@em...> - 2005-02-27 01:08:51
|
Hiroo Hayashi wrote: >Joe, > >Your tool should have a way to know which CVS tags exist. > True, but CVS is so complicated that I wasn't sure if IDEA was just hiding the tags from me because it wasn't the version that I had checked out. >Please revert your change. > Okay. I'll have to do that tonight. However, how much do you want me to revert? I added a method to DevicesConfig which is not used by anything else except my new JTree, so I don't see the harm in leaving it there since it'll be unused by anything once I put the original JList back in place of the JTree. Also, If I could (I almost did this anyway last night), I'd prefer to put the whole building and management of the JTree into its own class ("DeviceTree", for example). Then, I can still work on it, but it won't cause any problems because, again, nothing will actually *using* it. In short, there'd be unused code in the CVS tree in *anticipation* of future revisions. Would that be okay, or would you rather not have any of the unused code there at all? >If you cannot wait for Brian to create the >tag, you can create the tag. > Well, that would make me feel a little selfish... forking the code just because I want my stuff included *now*. I don't mind reverting my changes, but it would be nice if I could leave some of the stuff *in* but *unused* so that I don't have to keep the work I've currently done in some text file on my desktop until it's safe for me to paste them into the source again. - Joe |