From: Joachim B. <jba...@pi...> - 2005-02-01 07:10:30
|
Hi, I added a comment in MidiScan.java. > And please fix indentation, too. For the indentation issue: Please use a different editor than Eclipse to compare (use an indenation level of 4 for a tab): My changed code looks good in: Eclipse 3.0.1, UltraEdit, PSPad, SciTE Best regards, Joachim Backhaus > -----Urspr=FCngliche Nachricht----- > Von: jsy...@li... > [mailto:jsy...@li...]Im=20 > Auftrag von Hiroo > Hayashi > Gesendet: Dienstag, 1. Februar 2005 06:19 > An: JSynthLib Development > Betreff: [Jsynthlib-devel] MidiScan fix >=20 >=20 > Hi, Joachim, >=20 > I took a look at your recent check-in into core. Thank you very much. >=20 > jbackhaus> Modified Files: > jbackhaus> MidiScan.java=20 > jbackhaus> Log Message: > jbackhaus> Waldorf Microwave 2 is now recognized per Auto-Scan. > jbackhaus>=20 > jbackhaus> It uses a different inquiry response header: > jbackhaus> F7 7E 06 02 channel > jbackhaus> instead of > jbackhaus> F7 7E channel 06 02 >=20 > This means "Waldorf Microwave 2" does not obey the MIDI=20 > specification.=20 > It's not bad idea to put a hack for a particular synth. (Let's support > more synths!) But please put a comment. Otherwise nobody cannot > understand this code. >=20 > And please fix indentation, too. >=20 > Thank you, again. > --=20 > Hiroo Hayashi >=20 >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive=20 > Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Jsynthlib-devel mailing list > Jsy...@li... > https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel >=20 |