EnvelopeWidget update (Re: [Jsynthlib-devel] Roland GP16 and JSynthLib 0.20)

[Hiroo H. <hir...@co...>]

Hi,

I've checked in new Envelope Widget.  Both of the issues reported by
Thorsten were fixed. In addition to them I made the following changes.

  1. Implement setFaderValue, setValue, setEnabled() correctly.
  2. Reduce number of loop code to improve efficiency.
  3. Make use of better data structure and member names.

For example, now the envelope curve is moved by receiving fader control
events.  I made test by using KAWAI K4 and YAMAHA DX7 editor as far as
possible. But I made change the code so much that I'm still afraid that
I made some mistakes.  Please try to test the new code with your drivers.

Thanks.

Thorsten> Two additional comments:
Thorsten> 
Thorsten>    o the sustain parameter of an ADSR envelope cannot be
Thorsten>      modified anymore, once it has reached the maximum
Thorsten>      value. The same is the case for the delay parameter
Thorsten>      of a DADRS envelope if it has the minimum value - 
Thorsten>      this makes the envelope widget useless :-(
Thorsten> 
Thorsten>      Envelopes were working ok with 0.18, so it must be 
Thorsten>      related to one of the last changes
Thorsten> 
Thorsten> 
Thorsten>    o feature request: it would be nice if the SysEx parameter
Thorsten>      would be sent out immediately on changes in the 
Thorsten>      envelope. In the meantime I've replaced all envelopes 
Thorsten>      by knobs just for better realtime control
Thorsten>      (-> see also http://www.ucapps.de/midibox_fm.html )
Thorsten> 
Thorsten> Best Regards, Thorsten.
-- 
Hiroo Hayashi