Re: [Jsynthlib-devel] some core update

[Hiroo H. <hir...@co...>]

Hi,

Last Saturday I checked in the fix for this issue.  Instead of reverting
my change, I made the following fix;
        1. defined a static field PatchEditorFrame.nFrame which count
           patch editor frame opened.
        2. The first editor frame window is opened, a patch is sent.
        3. When there are only more one editor windows opened, a patch
           is sent every time a editor frame is activated.
        4. When two windows are opened and one of editor is closed, next
           time the other editor remained is activated, a patch is sent.

This covers the case which Torsten pointed out and does not send a patch
every time a patch editor is activated if only one editor window is
opened (most usual case).  Actual code was simpler than my bad English:-)

Hiroo> Torsten> > 3. PatchEditorFrame send the patch being edited only when the window is
Hiroo> Torsten> > opened.
Hiroo> Torsten> > 
Hiroo> Torsten> > Before every time the window is selected, the patch being edited was
Hiroo> Torsten> > sent to synth's edit buffer by using send() method.  This was verbose.
Hiroo> Torsten> 
Hiroo> Torsten> I don't think it's verbose.
Hiroo> 
Hiroo> Torsten> At least not if you edit several patches of one synthesizer
Hiroo> Torsten> at one time.  Maybe this is not the common way, but if you
Hiroo> Torsten> like to edit a patch and simoultanesly hold the original
Hiroo> Torsten> patch for comparison it's helpful.
Hiroo> 
Hiroo> I never thought of the case.  This is a good reason to send the patch
Hiroo> every time a edit window is activated.  I'll revert the change (with
Hiroo> some comments).

-- 
Hiroo Hayashi