Re: [Jsynthlib-devel] some core update

[<tt_...@gm...>]

Hi Hiroo,

Hiroo Hayashi wrote:
> Torsten> > BTW during this work, a question came to me.
> Torsten> > 
> Torsten> > The bank editor has a command 'delete'.  It 'delete's selected patches 
> Torsten> > (now).  But what the command does is just replace the patch name deleted
> Torsten> > to white spaces.  Do we really need the 'delete' command?
> 
> Torsten> I think so. Because if you like to remove a patch from a bank
> Torsten> you have to replace it manually by another patch.
> 
> My question might be ambiguous.
> 
> In what situation do you like to remove a patch from a bank?  We
> cannot really delete a patch from a bank.  What we can do is changing
> a patch name (the current implementation) or putting a default new
> patch (as you proposed).

You are absolutly right and I thought about the same question without finding a satisfying question.

> Torsten> The old way is easier and clearer.
> 
> Torsten> Maybe it's better to replace the patch with a default (the
> Torsten> "new") patch instead with withe spaces to ensure a valid
> Torsten> patch structure.
> 
> The my question may be "why do you have to have IBankPatch.delete(int)
> (BankDriver.deletePatch(Patch, int) method?".  Your proposal make it
> possible to obsolete IBankPatch.delete(int) method.
> 
> Again I don't understand when we like to remove a patch from a bank.
> Without doing that, I cannot choose a better way.

The only reason I found is a "cosmetical" reason.
For example if you create a bank patch, which includes only patches of a certain sound or for a single song, and don't want to hold any 
not needed patches in this bank.

To answer your question I propose to hold the method just for this reason. And I think it doesn't hurt to hold the "delete" method.
But as you already mentioned this isn't a forcible reason.
An user, who want to "clean" a bank patch, can copy a default patch to the bank to overwrite an unwanted patch.

I agree to you that it's not consistent to hold the "delete" method, because we can't delete single patches from bank patches as you wrote.

I hope my intention about this topic gets clearer to you.

Bye
Torsten