Re: [Jsynthlib-devel] some core update

[Hiroo H. <hir...@co...>]

Hi Torsten,

Torsten> > 3. PatchEditorFrame send the patch being edited only when the window is
Torsten> > opened.
Torsten> > 
Torsten> > Before every time the window is selected, the patch being edited was
Torsten> > sent to synth's edit buffer by using send() method.  This was verbose.
Torsten> 
Torsten> I don't think it's verbose.

Torsten> At least not if you edit several patches of one synthesizer
Torsten> at one time.  Maybe this is not the common way, but if you
Torsten> like to edit a patch and simoultanesly hold the original
Torsten> patch for comparison it's helpful.

I never thought of the case.  This is a good reason to send the patch
every time a edit window is activated.  I'll revert the change (with
some comments).

Torsten> > BTW during this work, a question came to me.
Torsten> > 
Torsten> > The bank editor has a command 'delete'.  It 'delete's selected patches 
Torsten> > (now).  But what the command does is just replace the patch name deleted
Torsten> > to white spaces.  Do we really need the 'delete' command?

Torsten> I think so. Because if you like to remove a patch from a bank
Torsten> you have to replace it manually by another patch.

My question might be ambiguous.

In what situation do you like to remove a patch from a bank?  We
cannot really delete a patch from a bank.  What we can do is changing
a patch name (the current implementation) or putting a default new
patch (as you proposed).

Torsten> The old way is easier and clearer.

Torsten> Maybe it's better to replace the patch with a default (the
Torsten> "new") patch instead with withe spaces to ensure a valid
Torsten> patch structure.

The my question may be "why do you have to have IBankPatch.delete(int)
(BankDriver.deletePatch(Patch, int) method?".  Your proposal make it
possible to obsolete IBankPatch.delete(int) method.

Again I don't understand when we like to remove a patch from a bank.
Without doing that, I cannot choose a better way.

Thanks.
-- 
Hiroo Hayashi