Re: [Jsynthlib-devel] some core update

[<tt_...@gm...>]

Hi Hiroo,

Hiroo Hayashi wrote:
> 3. PatchEditorFrame send the patch being edited only when the window is
> opened.
> 
> Before every time the window is selected, the patch being edited was
> sent to synth's edit buffer by using send() method.  This was verbose.

I don't think it's verbose.
At least not if you edit several patches of one synthesizer at one time.
Maybe this is not the common way, but if you like to edit a patch and simoultanesly hold the original patch for comparison it's helpful.
In the past you don't need to send the patch explicitly but you only need to activate the window.
Another topic is the fact that playing a patch doesn't send the patch.
So if you like to compare 2 patches you only needed to activate the desired window and play the patch.
Now you have to activate the desired window, send the patch and play the patch.

I think the old way was easier and clearer. If you activated a window the synth holded the current patch.
Now you have to send the patch explicitly. If you forget to send the patch the synth holds not the current patch and you don't hear the 
sound you are expecting.

> BTW during this work, a question came to me.
> 
> The bank editor has a command 'delete'.  It 'delete's selected patches 
> (now).  But what the command does is just replace the patch name deleted
> to white spaces.  Do we really need the 'delete' command?

I think so. Because if you like to remove a patch from a bank you have to replace it manually by another patch.
The old way is easier and clearer.
Maybe it's better to replace the patch with a default (the "new") patch instead with withe spaces to ensure a valid patch structure.

Bye
Torsten